refactor: extract native module type specific code into its own files #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is almost entirely a refactor of existing code, namely moving code relating to each native module type (
node-gyp,prebuild-install,prebuildify) into their own files, which should make it easier to add new native module types, e.g., #367, #337, and #268.This makes
ModuleRebuildera shell of its former self, so a future PR will refactor that class back intoRebuilder(and probably extract things like the node module walker out ofRebuilder).There is one fix here, mostly because this PR caused the other one to have merge conflicts:
fix: only set --verbose for node-gyp if DEBUG for rebuild is setNote: this will 100% cause merge conflicts with #703.
Fixes #594.
Closes #689.