Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add E2EE Url Preview Passthrough in the room settings #6090

Closed
wants to merge 1 commit into from

Conversation

Baconxrp
Copy link

@Baconxrp Baconxrp commented May 18, 2022

Type of change

  • [ x] Feature
  • Bugfix
  • Technical
  • Other :

Content

add E2EE Url Preview Passthrough that was recently added to the web/desktop version of element in the room settings to both android and ios.

It was a change that allowed the user on desktop/web to be able to go into an ENCRYPTED room and have a choice to be able to see url previews if they wish to.

Motivation and context

The motivation is simple. I currently have EE2E URL preview passthrough on desktop/web when i talk to my friends at home and they send me links over dms and it is nice to see the preview on them that I chose to change the room setting on. I want to be able to also do this on my phone / mobile device.

Thank you!

Screenshots / GIFs

Screenshot_36_20220326100057_20220327064415~2

Base branch is now on develop per bmarty's request. Hope i did it correctly

Id like to add that schildichat for android has e2ee passthrough in its labs section. Might be a good clue and the reason why i think it should be added is because schildichat is not available for ios.

@github-actions
Copy link

Unit Test Results

122 files  ±0  122 suites  ±0   2m 4s ⏱️ +2s
205 tests ±0  205 ✔️ ±0  0 💤 ±0  0 ±0 
690 runs  ±0  690 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 4184aab. ± Comparison against base commit 6c8e047.

@bmarty
Copy link
Member

bmarty commented May 18, 2022

This time (last attempt was #5818), the PR is empty. Can you double check please?

image

@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label May 18, 2022
@Baconxrp
Copy link
Author

This time (last attempt was #5818), the PR is empty. Can you double check please?

image

No idea on how to do that. Probably ganna give up after this because i dont understand anything about this site and all i wanted to do was put forward a feature request. Im not a developer to any span of the imagination.

@bmarty
Copy link
Member

bmarty commented May 18, 2022

This time (last attempt was #5818), the PR is empty. Can you double check please?
image

No idea on how to do that. Probably ganna give up after this because i dont understand anything about this site and all i wanted to do was put forward a feature request. Im not a developer to any span of the imagination.

I see. In this case you have to open an issue navigating to https://github.com/vector-im/element-android/issues and clicking on "New Issue" and not create a pull request which are a thing to submit changes in the code.

For this particular case, please do not create a new issue, there is already an existing one that you can comment if you want to: #2555

Thanks!

@bmarty bmarty closed this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants