Feature: add E2EE Url Preview Passthrough in the room settings #5818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng_permission VoIP Screen Sharing Permission
Move to using hookshot to send notifications, rather than using matrix client directly.
Improve code in file TimelineEventEntityQueries.kt
Add a fun `RegistrationWizard.registrationCustom()` to be able to use any parameters during the registration. Move terms converter into `api` package.
Unit Test Results122 files + 46 122 suites +46 2m 13s ⏱️ + 1m 15s Results for commit 0b00f97. ± Comparison against base commit 4ce1ab2. This pull request removes 9 and adds 70 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Hey @Baconxrp , thanks for your PR! This diff is quite strange, can you ensure that the base branch is set to our Then we will be able to review it. Thanks |
Currently translated at 40.2% (893 of 2217 strings) Translation: Element Android/Element Android App Translate-URL: https://translate.element.io/projects/element-android/element-app/ar/
Currently translated at 99.8% (2213 of 2217 strings) Translation: Element Android/Element Android App Translate-URL: https://translate.element.io/projects/element-android/element-app/et/
Currently translated at 100.0% (2217 of 2217 strings) Translation: Element Android/Element Android App Translate-URL: https://translate.element.io/projects/element-android/element-app/it/
Currently translated at 96.8% (2148 of 2217 strings) Translation: Element Android/Element Android App Translate-URL: https://translate.element.io/projects/element-android/element-app/ja/
Currently translated at 100.0% (2217 of 2217 strings) Translation: Element Android/Element Android App Translate-URL: https://translate.element.io/projects/element-android/element-app/zh_Hant/
Currently translated at 100.0% (57 of 57 strings) Translation: Element Android/Element Android Store Translate-URL: https://translate.element.io/projects/element-android/element-store/et/
Currently translated at 100.0% (57 of 57 strings) Translation: Element Android/Element Android Store Translate-URL: https://translate.element.io/projects/element-android/element-store/zh_Hant/
Sorry, im unsure how to do that. Im just putting this out there as an individual who runs a matrix server and hasn't federated yet because this feature hasn't been fully implemented across all platforms. Been running our server for close to two years now. Hopefully it comes out so we can federate. |
Currently translated at 42.4% (942 of 2217 strings) Translation: Element Android/Element Android App Translate-URL: https://translate.element.io/projects/element-android/element-app/ar/
Currently translated at 100.0% (2217 of 2217 strings) Translation: Element Android/Element Android App Translate-URL: https://translate.element.io/projects/element-android/element-app/fa/
Bumps [libphonenumber](https://github.com/google/libphonenumber) from 8.12.47 to 8.12.48. - [Release notes](https://github.com/google/libphonenumber/releases) - [Changelog](https://github.com/google/libphonenumber/blob/master/making-metadata-changes.md) - [Commits](google/libphonenumber@v8.12.47...v8.12.48) --- updated-dependencies: - dependency-name: com.googlecode.libphonenumber:libphonenumber dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…ode.libphonenumber-libphonenumber-8.12.48 Bump libphonenumber from 8.12.47 to 8.12.48
Reformats project based on editorconfig
…rendering_issue_5151 Feature/aris/threads improve rendering issue 5151
Correct public_baseurl for nightly tests.
Fixed dependabot
Dependabot reviewers
Add diag request for Synapse
* Fork sonarqube run into a nightly build, report failures back to channel. * Each PR triggers a build after merge, report failures back to channel.
noop change to test build system
Fix typo - pull-request -> pull_request
…st-post-pr noop change to trigger another PR
…_to_test_post_pr noop change to test Post PR merging
…eck_post_pr_check noop change to README to test post-pr merging
|
Sorry, there is a pb with this PR, please create it again
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
add E2EE Url Preview Passthrough that was recently added to the web/desktop version of element in the room settings to both android and ios.
It was a change that allowed the user on desktop/web to be able to go into an ENCRYPTED room and have a choice to be able to see url previews if they wish to.
Motivation and context
The motivation is simple. I currently have EE2E URL preview passthrough on desktop/web when i talk to my friends at home and they send me links over dms and it is nice to see the preview on them that I chose to change the room setting on. I want to be able to also do this on my phone / mobile device.
Thank you!
Screenshots / GIFs