Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the device that's actually in use #1670

Draft
wants to merge 4 commits into
base: livekit
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/livekit/useLiveKit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,12 @@ export function useLiveKit(
const syncDevice = (kind: MediaDeviceKind, device: MediaDevice) => {
const id = device.selectedId;
if (id !== undefined && room.getActiveDevice(kind) !== id) {
logger.info(
`Switching ${kind} device to ${
device.available.find((d) => d.deviceId === device.selectedId)
?.label
} (${id})`
);
room
.switchActiveDevice(kind, id)
.catch((e) =>
Expand Down
88 changes: 74 additions & 14 deletions src/settings/SettingsModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ import { ChangeEvent, Key, useCallback, useState } from "react";
import { Item } from "@react-stately/collections";
import { Trans, useTranslation } from "react-i18next";
import { MatrixClient } from "matrix-js-sdk";
import { useMaybeRoomContext } from "@livekit/components-react";
import { LocalTrack } from "livekit-client";
import { logger } from "matrix-js-sdk/src/logger";

import { Modal } from "../Modal";
import styles from "./SettingsModal.module.css";
Expand Down Expand Up @@ -66,26 +69,79 @@ export const SettingsModal = (props: Props) => {
useShowConnectionStats();
const [enableE2EE, setEnableE2EE] = useEnableE2EE();

// Generate a `SelectInput` with a list of devices for a given device kind.
const generateDeviceSelection = (devices: MediaDevice, caption: string) => {
const lkRoom = useMaybeRoomContext();

const getTrackInUse = (sourceName: string): LocalTrack | undefined => {
if (!lkRoom) return undefined;

const t = Array.from(lkRoom.localParticipant.audioTracks.values()).find(
(d) => d.source === sourceName
);

return t?.track;
};

/**
* Generate a `SelectInput` with a list of devices for a given device kind.
* @param devices Info about the available & selected devices from MediaDevicesContext
* @param caption Device caption to be used if no labels available
* @param lkSource The livekit source name for this device type, eg. 'microphone': used to match up
* devices used by tracks in a current room (if any).
*/
const generateDeviceSelection = (
devices: MediaDevice,
caption: string,
lkSource?: string
) => {
if (devices.available.length == 0) return null;

const trackUsedByRoom = lkSource ? getTrackInUse(lkSource) : undefined;

let selectedKey = devices.selectedId;
// We may present a different device as the currently selected one if we have an active track
// from the default device, because the default device may have changed since we acquired the
// track, in which case we want to display the one we're actually using rather than what the
// default is now.
dbkr marked this conversation as resolved.
Show resolved Hide resolved
if (
trackUsedByRoom &&
(devices.selectedId === "" ||
!devices.selectedId ||
devices.selectedId === "default")
) {
// we work out what the actual device is based on groupId, but this only works if
// there is only one such device with the same group ID, which there won't be if
// we're using hardware with multiple sub-devices (eg. a multitrack soundcard)
const usedGroupId =
trackUsedByRoom?.mediaStreamTrack.getSettings().groupId;
const devicesWithMatchingGroupId = devices.available.filter(
(d) => d.groupId === usedGroupId && d.groupId !== "default"
toger5 marked this conversation as resolved.
Show resolved Hide resolved
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the last pr. Could the label also work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might involve comparing here which is tricky because chrome prepends 'Default: ' so we'd have to work around that and however it i18ns on the user's system.


if (devicesWithMatchingGroupId.length === 1) {
logger.info(
`Current default device doesn't appear to match device in use: selecting ${devicesWithMatchingGroupId[0].label}`
);
selectedKey = devicesWithMatchingGroupId[0].deviceId;
}
}

const getLabel = (device: MediaDeviceInfo, index: number) => {
/*if (selected && trackUsedByRoom) {
return trackUsedByRoom.label.trim();
}*/
return !!device.label && device.label.trim().length > 0
? device.label
: `${caption} ${index + 1}`;
};

return (
<SelectInput
label={caption}
selectedKey={
devices.selectedId === "" || !devices.selectedId
? "default"
: devices.selectedId
}
selectedKey={selectedKey}
onSelectionChange={(id) => devices.select(id.toString())}
>
{devices.available.map(({ deviceId, label }, index) => (
<Item key={deviceId}>
{!!label && label.trim().length > 0
? label
: `${caption} ${index + 1}`}
</Item>
{devices.available.map((d, index) => (
<Item key={d.deviceId}>{getLabel(d, index)}</Item>
))}
</SelectInput>
);
Expand Down Expand Up @@ -124,7 +180,11 @@ export const SettingsModal = (props: Props) => {
</>
}
>
{generateDeviceSelection(devices.audioInput, t("Microphone"))}
{generateDeviceSelection(
devices.audioInput,
t("Microphone"),
"microphone"
)}
{!isFirefox() &&
generateDeviceSelection(devices.audioOutput, t("Speaker"))}
</TabItem>
Expand Down