Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions: Show at most N keys #2510

Closed
manuroe opened this issue Jun 19, 2019 · 0 comments · Fixed by #2549
Closed

Reactions: Show at most N keys #2510

manuroe opened this issue Jun 19, 2019 · 0 comments · Fixed by #2549
Assignees
Labels
A-Aggregations A-Redaction feature T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@manuroe
Copy link
Member

manuroe commented Jun 19, 2019

From riot-web created by jryans: element-hq/element-web#9570

To avoid showing potentially 100s of reaction keys (where a "key" is a single emoji that many may have sent in aggregate, not a single vote) on a single message, we will limit to at most N keys. (This is intentionally written as just a limit without any sorting implied. See https://github.com/vector-im/riot-web/issues/9698 for sorting.)

For all rooms (unencrypted and encrypted), the client will show at most N keys inline with the message, and then add a "view more" disclosure to see the rest if there's more than that.

We're currently thinking N will be 8.

@manuroe manuroe self-assigned this Jul 3, 2019
manuroe added a commit that referenced this issue Jul 4, 2019
manuroe added a commit that referenced this issue Jul 4, 2019
@kittykat kittykat added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Aggregations A-Redaction feature T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants