Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions: Sort keys by time of first appearance #772

Closed
jryans opened this issue May 13, 2019 · 9 comments
Closed

Reactions: Sort keys by time of first appearance #772

jryans opened this issue May 13, 2019 · 9 comments
Labels
A-Aggregations A-Reactions good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@jryans
Copy link

jryans commented May 13, 2019

...instead of by vote count.

@lampholder
Copy link
Member

Are we certain we want this? Isn't vote count more informative?

@jryans
Copy link
Author

jryans commented May 31, 2019

I think @nadonomy's argument was that it's less surprising, allows you to build "messages" out of the emoji ordering (like 🛫🇬🇧🛬), and it means the emoji key won't move out from under you when you increment it.

Is that correct @nadonomy?

@nadonomy
Copy link

nadonomy commented May 31, 2019

Correct. To expand a little; that user behaviour is already fairly well engrained from usage on other platforms, and it also allows early reactors (including the message sender themselves) to instigate what reactions they want to see more of— e.g. 🍾 on announcements.

That, plus the current functionality of reactions dancing around your screen as you interact with them is unexpected and pretty frustrating.

There could be an argument for sorting by number of reactions when viewing older messages, but (a) that might break the 'storytelling' aspect of choosing what order to send reactions and (b) it makes it more complicated than it needs to be— figuring out the heuristics for when to switch e.g. after an amount of time, but only on timeline load so existing reactions don't unexpectedly change sort order etc so I'd prefer to look at that as a future refinement, if at all.

@lampholder
Copy link
Member

SGTM

@jryans
Copy link
Author

jryans commented May 31, 2019

Added an MSC comment to discuss whether the bundled reactions data will support this.

@daenney
Copy link

daenney commented Apr 20, 2021

I find the current behaviour really jarring. If there's multiple emoji reactions and you click on one of them, it suddenly "teleports" away from under your cursor as the list reshuffles and a new emoji ends up under your cursor, leaving the impression you miss-clicked.

@SimonBrandner SimonBrandner added the X-Needs-Product More input needed from the Product team label Apr 20, 2021
@robintown robintown added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Mar 18, 2022
@anoadragon453
Copy link
Member

(Reposting from element-hq/element-web#22698)

I can confirm that this is a bit of fun communities very often take part in on Discord.

image
image
image

Particularly in announcement channels, where users can only interact via emojis.


Interestingly, looking at the above screenshots you can see that even though reactions aren't sorted by count on Discord, you almost end up with that sorting occurring anyways. This is likely because (in left-to-right reading countries) people will start looking, and reacting, from the left-most reaction to the right.

So if one is looking to see the most upvoted answer, that may happen naturally anyways. Sacrificing original reaction order may not be worth it. This information could also possibly be exposed elsewhere, such as the proposed feature of a modal showing which users have reacted with which emoji.

A final argument. Re-ordering reactions is annoying when you're attempting to garner interest from others via reactions (or a bot is using them for user responses). A bot may post a message like the following:

Choose the categories of events you'd like to be notified about!

🎤 Weekly tech talks.
🎮 Community game streams.
🎖️ Speed-running competitions.
🎥 Movie nights.
👩‍🍳 Group cooking nights.

Typically the bot would then react to the message with each emoji in the same order as the list above, so that it's easy to cross-reference. But with inconsistent reaction ordering, this can end up complicating the user experience.

image

@nadonomy nadonomy added good first issue Good for newcomers and removed X-Needs-Product More input needed from the Product team labels Jun 30, 2022
@anoadragon453
Copy link
Member

image

This behaviour has started to show up in the Synapse announcements room.

@babolivier
Copy link

This behaviour has started to show up in the Synapse announcements room.

It's actually happened a few times now and has been consistently mangled by Element ☹️

image

@t3chguy t3chguy transferred this issue from element-hq/element-web Oct 17, 2022
@element-hq element-hq locked and limited conversation to collaborators Oct 17, 2022
@t3chguy t3chguy converted this issue into discussion #773 Oct 17, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
A-Aggregations A-Reactions good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

No branches or pull requests

8 participants