Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new Thread by replying to a message #5089

Merged
merged 126 commits into from
Jan 26, 2022
Merged

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Nov 3, 2021

Fix #5068 & #5069 & #5093 & #5266

@ismailgulek
Copy link
Contributor Author

ismailgulek commented Nov 3, 2021

ios_message_actions

ios_timeline
ios_timeline_dark

ios_thread_plain_dark_portrait
ios_thread_plain_dark_landscape

Encrypted room:
ios_thread_encrypted_dark

@ismailgulek ismailgulek linked an issue Nov 3, 2021 that may be closed by this pull request
3 tasks
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/oLCCoN

@ismailgulek ismailgulek changed the base branch from ismail/threads to develop November 11, 2021 12:20
Copy link

@janogarcia janogarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ismailgulek Thank you for providing a build containing all the Threads features you've been working on. I've reviewed it in detail and documented all the stuff that would need to be tweaked/improved. 👍

Please find all the details on the following annotated screenshots:

Implementation Review · P0 iOS · r01
https://www.figma.com/file/T309ztx0sNyOOK6NKVLHsK/Threads?node-id=2939%3A286198

Thanks!


Snapshot (partial)

Threads – Figma

@janogarcia
Copy link

janogarcia commented Dec 23, 2021

@ismailgulek Quick update: I've added links to the mockups for the Thread List empty states.


Threads – Figma

@janogarcia
Copy link

@ismailgulek Update: Added a note on applying the correct sizing rules for the Thread Summary component.


SCR-20211217-ea6-15

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 😎

I've added comments inline. One more general thought:

Should the new views be configuring the their labels using fonts from the theme rather than purely being set in the xibs/storyboards?

Riot/Assets/en.lproj/Vector.strings Outdated Show resolved Hide resolved
Riot/Modules/Application/LegacyAppDelegate.m Outdated Show resolved Hide resolved
Riot/Modules/Application/LegacyAppDelegate.m Outdated Show resolved Hide resolved
Riot/Modules/Common/Recents/RecentsViewController.m Outdated Show resolved Hide resolved
Riot/Modules/MatrixKit/Models/Room/MXKRoomDataSource.h Outdated Show resolved Hide resolved
Riot/Modules/Threads/ThreadsCoordinator.swift Show resolved Hide resolved
Riot/Routers/PresentableModule.swift Outdated Show resolved Hide resolved
Riot/Routers/NavigationRouter.swift Show resolved Hide resolved
Riot/Modules/Room/RoomViewController.m Outdated Show resolved Hide resolved
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Can't wait for this to land.

There's a few places where the variable/parameter is still called xyzViewModel after the type was renamed to xyzModel but that's only a minor thought.

@ismailgulek ismailgulek merged commit 1bb3a06 into develop Jan 26, 2022
@ismailgulek ismailgulek deleted the ismail/5068_start_thread branch January 26, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants