Design Tweaks for Threads #5356
Conversation
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/UnK94h |
|
This request couldn't be handled, as we don't have control over those items when we display an action sheet.
|
There was a problem hiding this comment.
@ismailgulek Thank you, Ismail! I've reviewed it in detail and documented all the stuff that would need to be tweaked/improved. 👍
Please find all the details on the following annotated screenshots:
Implementation Review · P0 iOS · r02
https://www.figma.com/file/T309ztx0sNyOOK6NKVLHsK/Threads?node-id=3279%3A338959
Thanks!
Snapshot (partial)
Riot/Assets/Images.xcassets/Room/Threads/threads_filter_applied.imageset/Contents.json
Show resolved
Hide resolved
| if let lastMessage = viewModel.lastMessageText { | ||
| let mutable = NSMutableAttributedString(attributedString: lastMessage) | ||
| mutable.setAttributes([ | ||
| .font: Constants.lastMessageFont |
There was a problem hiding this comment.
Following on from the fonts comment on the last PR, perhaps this should be
| .font: Constants.lastMessageFont | |
| .font: theme.fonts.footnote |
There was a problem hiding this comment.
Let's not do this for now, as it'll enable dynamic type for that label. We can do it when we support dynamic type app-wide.
There was a problem hiding this comment.
Ahhh. Think I used those for URL previews 🙈
Riot/Modules/GlobalSearch/Messages/DataSources/HomeMessagesSearchDataSource.m
Outdated
Show resolved
Hide resolved
Riot/Modules/GlobalSearch/Messages/DataSources/HomeMessagesSearchDataSource.m
Outdated
Show resolved
Hide resolved
Design tweaks for #5089