Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hitting the Ctrl key bring the cursor back to the editor #10390

Closed
babolivier opened this issue Jul 22, 2019 · 16 comments
Closed

Hitting the Ctrl key bring the cursor back to the editor #10390

babolivier opened this issue Jul 22, 2019 · 16 comments
Labels
A-Aggregations A-Message-Editing T-Defect X-Regression

Comments

@babolivier
Copy link
Contributor

Peek 2019-07-22 15-12

The text I've highlighted un-highlights itself and the cursor is brought back to the editor when I hit Ctrl, which prevents me from e.g. copying text using Ctrl+C.

Observed on latest develop, with Firefox on GNU/Linux.
@jryans
Copy link
Collaborator

jryans commented Jul 24, 2019

Hmm, I would have expected matrix-org/matrix-react-sdk#3237 to fix this ~5 days ago. What precise version of develop do you have?

@babolivier
Copy link
Contributor Author

babolivier commented Jul 24, 2019 •
edited
Loading

I'm always using riot.im/develop
For some reason it stopped doing that the day after I opened the issue (edit: which is yesterday). However, it still does it if I select the two words around a space by double-clicking on the space:

Peek 2019-07-24 11-26

@bwindels
Copy link
Contributor

I think Ryan was referring the version in "Help & About" in the settings you were seeing. /develop puts the git hashes of our 3 libraries there, e.g. for me atm:

riot-web version: 55e2f18-react-e73690439f2f-js-6cca73b9998c

This helps to exclude your cache isn't stale for some reason :)

I tried to reproduce both reported behaviours (normal selection, and selecting by double clicking space between words), but couldn't trigger the composer to focus for either on Firefox 68 on Fedora 30.

@babolivier
Copy link
Contributor Author

babolivier commented Jul 24, 2019 •
edited
Loading

Right, sorry, my current version is 55e2f18d1e46-react-ac31b4b8f411-js-6cca73b9998c and I'm reproducing the space one (can't reproduce the normal selection one anymore, and I've no idea what my version of Riot was then) on Firefox 68 on Archlinux.

@anoadragon453
Copy link
Member

Cannot reproduce on Debian Buster, Firefox v70.0a1. Maybe a GNOME thing?

@bwindels
Copy link
Contributor

I'm on GNOME fwiw

@babolivier
Copy link
Contributor Author

babolivier commented Jul 25, 2019 •
edited
Loading

For some reason the bug as shown in the issue's initial comment just reappeared.

Riot version is 55e2f18d1e46-react-cef67d5784fa-js-6cca73b9998c

@bwindels
Copy link
Contributor

For some reason the bug as shown in the issue's initial comment just reappeared.

Riot version is 55e2f18d1e46-react-cef67d5784fa-js-6cca73b9998c

Thanks for reporting. I am still unable to reproduce anything alike unfortunately :(

Nothing interesting in the console I suppose?
Could you send a profiling session while reproducing? (in browser devtools, go to "Performance" tab, hit start recording, reproduce, hit stop, and save.)
Does it also happen in Chromium? If so, please do the profiling there as it's a bit more informative.

@jryans
Copy link
Collaborator

jryans commented Jul 25, 2019

Could you send a profiling session while reproducing? (in browser devtools, go to "Performance" tab, hit start recording, reproduce, hit stop, and save.)

As an aside, if you want good profiling in Firefox, I recommend trying one of the following:

  1. Use Firefox Nightly
  2. In DevTools, go to 3 dots -> Settings -> Enable new performance recorder
  3. Re-open DevTools
  4. Capture in Performance tab

or

  1. Go to https://profiler.firefox.com
  2. Install add-on as it suggests
  3. Use add-on to capture and share a profile

@lnicola
Copy link

lnicola commented Aug 8, 2019 •
edited
Loading

I started seeing this after upgrading from 1.3.0 to 1.3.2. The selection is dismissed when I press Ctrl. This happens if the compose box had focus before selecting the text. If I focus the Developer Tools, the selection is no longer dismissed.

Firefox on Gnome, Wayland.

@bwindels
Copy link
Contributor

Hmm, I indeed see (Linux, Gnome & Wayland) a keyboard event for just pressing Control on Chromium but not Firefox. If they ctrlKey flag isn't set on this event, it would explain things, but for me this flag is set. I'm adding some extra checks to not refocus when just pressing a modifier key, regardless of the state of the modifier flags. Let's see if that helps.

@bwindels bwindels mentioned this issue Aug 20, 2019
Merged
@jryans
Copy link
Collaborator

jryans commented Aug 21, 2019

@bwindels has a possible fix for this that has now landed on develop. Please refresh and see if it helps.

@lnicola
Copy link

lnicola commented Sep 16, 2019

Did this get in riot-web 1.3.4? It still seems to happen (and it's pretty annoying TBH).

@bwindels
Copy link
Contributor

No, should land in Riot 1.4.0

@lnicola
Copy link

lnicola commented Sep 29, 2019

Seems fixed for me in 1.4.0. @babolivier, can you test?

@babolivier
Copy link
Contributor Author

Yep, can't reproduce anymore 👍

su-ex added a commit to SchildiChat/element-web that referenced this issue Apr 21, 2023
@su-ex
Merge tag 'v1.11.29' into sc
f88e48a 
* Allow desktop app to expose recent rooms in UI integrations ([\element-hq#16940](element-hq#16940)).
* Add API params to mute audio and/or video in Jitsi calls by default ([\element-hq#24820](element-hq#24820)). Contributed by @dhenneke.
* Style mentions as pills in rich text editor ([\element-hq#10448](matrix-org/matrix-react-sdk#10448)). Contributed by @alunturner.
* Show room create icon if "UIComponent.roomCreation" is enabled ([\element-hq#10364](matrix-org/matrix-react-sdk#10364)). Contributed by @maheichyk.
* Mentions as links rte ([\element-hq#10463](matrix-org/matrix-react-sdk#10463)). Contributed by @alunturner.
* Better error handling in jump to date ([\element-hq#10405](matrix-org/matrix-react-sdk#10405)). Contributed by @MadLittleMods.
* Show "Invite" menu option if "UIComponent.sendInvites" is enabled. ([\element-hq#10363](matrix-org/matrix-react-sdk#10363)). Contributed by @maheichyk.
* Added `UserProfilesStore`, `LruCache` and user permalink profile caching ([\element-hq#10425](matrix-org/matrix-react-sdk#10425)). Fixes element-hq#10559.
* Mentions as links rte ([\element-hq#10422](matrix-org/matrix-react-sdk#10422)). Contributed by @alunturner.
* Implement MSC3952: intentional mentions ([\element-hq#9983](matrix-org/matrix-react-sdk#9983)).
* Implement MSC3973: Search users in the user directory with the Widget API ([\element-hq#10269](matrix-org/matrix-react-sdk#10269)). Contributed by @dhenneke.
* Permalinks to message are now displayed as pills ([\element-hq#10392](matrix-org/matrix-react-sdk#10392)). Fixes element-hq#24751 and element-hq#24706.
* Show search,dial,explore in filterContainer if "UIComponent.filterContainer" is enabled ([\element-hq#10381](matrix-org/matrix-react-sdk#10381)). Contributed by @maheichyk.
* Increase space panel collapse clickable area ([\element-hq#6084](matrix-org/matrix-react-sdk#6084)). Fixes element-hq#17379. Contributed by @jaiwanth-v.
* Add fallback for replies to Polls ([\element-hq#10380](matrix-org/matrix-react-sdk#10380)). Fixes element-hq#24197. Contributed by @kerryarchibald.
* Permalinks to rooms and users are now pillified ([\element-hq#10388](matrix-org/matrix-react-sdk#10388)). Fixes element-hq#24825.
* Poll history -  access poll history from room settings ([\element-hq#10356](matrix-org/matrix-react-sdk#10356)). Contributed by @kerryarchibald.
* Add API params to mute audio and/or video in Jitsi calls by default ([\element-hq#10376](matrix-org/matrix-react-sdk#10376)). Contributed by @dhenneke.
* Notifications: inline error message on notifications saving error ([\#10288](matrix-org/matrix-react-sdk#10288)). Contributed by @kerryarchibald.
* Support dynamic room predecessor in SpaceProvider ([\element-hq#10348](matrix-org/matrix-react-sdk#10348)). Contributed by @andybalaam.
* Support dynamic room predecessors for RoomProvider ([\element-hq#10346](matrix-org/matrix-react-sdk#10346)). Contributed by @andybalaam.
* Support dynamic room predecessors in OwnBeaconStore ([\element-hq#10339](matrix-org/matrix-react-sdk#10339)). Contributed by @andybalaam.
* Support dynamic room predecessors in ForwardDialog ([\element-hq#10344](matrix-org/matrix-react-sdk#10344)). Contributed by @andybalaam.
* Support dynamic room predecessors in SpaceHierarchy ([\element-hq#10341](matrix-org/matrix-react-sdk#10341)). Contributed by @andybalaam.
* Support dynamic room predecessors in AddExistingToSpaceDialog ([\element-hq#10342](matrix-org/matrix-react-sdk#10342)). Contributed by @andybalaam.
* Support dynamic room predecessors in leave-behaviour ([\#10340](matrix-org/matrix-react-sdk#10340)). Contributed by @andybalaam.
* Support dynamic room predecessors in StopGapWidgetDriver ([\element-hq#10338](matrix-org/matrix-react-sdk#10338)). Contributed by @andybalaam.
* Support dynamic room predecessors in WidgetLayoutStore ([\element-hq#10326](matrix-org/matrix-react-sdk#10326)). Contributed by @andybalaam.
* Support dynamic room predecessors in SpaceStore ([\element-hq#10332](matrix-org/matrix-react-sdk#10332)). Contributed by @andybalaam.
* Sync polls push rules on changes to account_data ([\element-hq#10287](matrix-org/matrix-react-sdk#10287)). Contributed by @kerryarchibald.
* Support dynamic room predecessors in BreadcrumbsStore ([\element-hq#10295](matrix-org/matrix-react-sdk#10295)). Contributed by @andybalaam.
* Improved a11y for Field feedback and Secure Phrase input ([\element-hq#10320](matrix-org/matrix-react-sdk#10320)). Contributed by @Sebbones.
* Support dynamic room predecessors in RoomNotificationStateStore ([\#10297](matrix-org/matrix-react-sdk#10297)). Contributed by @andybalaam.
* Use a newly generated access_token while joining Jitsi ([\element-hq#24646](element-hq#24646)). Fixes element-hq#24687. Contributed by @emrahcom.
* Fix cloudflare action pointing at commit hash instead of tag ([\element-hq#24777](element-hq#24777)). Contributed by @justjanne.
* Allow editing with RTE to overflow for autocomplete visibility ([\element-hq#10499](matrix-org/matrix-react-sdk#10499)). Contributed by @alunturner.
* Added auto focus to Github URL on opening of debug logs modal ([\element-hq#10479](matrix-org/matrix-react-sdk#10479)). Contributed by @ShivamSpm.
* Fix detection of encryption for all users in a room ([\#10487](matrix-org/matrix-react-sdk#10487)). Fixes element-hq#24995.
* Properly generate mentions when editing a reply with MSC3952 ([\element-hq#10486](matrix-org/matrix-react-sdk#10486)). Fixes element-hq#24924. Contributed by @kerryarchibald.
* Improve performance of rendering a room with many hidden events ([\#10131](matrix-org/matrix-react-sdk#10131)). Contributed by @andybalaam.
* Prevent future date selection in jump to date ([\element-hq#10419](matrix-org/matrix-react-sdk#10419)). Fixes element-hq#20800. Contributed by @MadLittleMods.
* Add aria labels to message search bar to improve accessibility ([\element-hq#10476](matrix-org/matrix-react-sdk#10476)). Fixes element-hq#24921.
* Fix decryption failure bar covering the timeline ([\element-hq#10360](matrix-org/matrix-react-sdk#10360)). Fixes element-hq#24780 element-hq#24074 and element-hq#24183. Contributed by @luixxiul.
* Improve profile picture settings accessibility ([\element-hq#10470](matrix-org/matrix-react-sdk#10470)). Fixes element-hq#24919.
* Handle group call redaction ([\element-hq#10465](matrix-org/matrix-react-sdk#10465)).
* Display relative timestamp for threads on the same calendar day ([\#10399](matrix-org/matrix-react-sdk#10399)). Fixes element-hq#24841. Contributed by @kerryarchibald.
* Fix timeline list and paragraph display issues ([\element-hq#10424](matrix-org/matrix-react-sdk#10424)). Fixes element-hq#24602. Contributed by @alunturner.
* Use unique keys for voice broadcast pips ([\element-hq#10457](matrix-org/matrix-react-sdk#10457)). Fixes element-hq#24959.
* Fix "show read receipts sent by other users" not applying to threads ([\element-hq#10445](matrix-org/matrix-react-sdk#10445)). Fixes element-hq#24910.
* Fix joining public rooms without aliases in search dialog ([\element-hq#10437](matrix-org/matrix-react-sdk#10437)). Fixes element-hq#23937.
* Add input validation for `m.direct` in `DMRoomMap` ([\element-hq#10436](matrix-org/matrix-react-sdk#10436)). Fixes element-hq#24909.
* Reduce height reserved for "collapse" button's line on IRC layout ([\element-hq#10211](matrix-org/matrix-react-sdk#10211)). Fixes element-hq#24605. Contributed by @luixxiul.
* Fix `creatorUserId is required` error when opening sticker picker ([\element-hq#10423](matrix-org/matrix-react-sdk#10423)).
* Fix block/inline Element descendants error noise in `NewRoomIntro.tsx` ([\element-hq#10412](matrix-org/matrix-react-sdk#10412)). Contributed by @MadLittleMods.
* Fix profile resizer to make first character of a line selectable in IRC layout ([\element-hq#10396](matrix-org/matrix-react-sdk#10396)). Fixes element-hq#14764. Contributed by @luixxiul.
* Ensure space between wrapped lines of room name on IRC layout ([\#10188](matrix-org/matrix-react-sdk#10188)). Fixes element-hq#24742. Contributed by @luixxiul.
* Remove unreadable alt attribute from the room status bar warning icon (nonsense to screenreaders) ([\element-hq#10402](matrix-org/matrix-react-sdk#10402)). Contributed by @MadLittleMods.
* Fix big date separators when jump to date is enabled ([\element-hq#10404](matrix-org/matrix-react-sdk#10404)). Fixes element-hq#22969. Contributed by @MadLittleMods.
* Fixes user authentication when registering via the module API ([\element-hq#10257](matrix-org/matrix-react-sdk#10257)). Contributed by @maheichyk.
* Handle more edge cases in Space Hierarchy ([\element-hq#10280](matrix-org/matrix-react-sdk#10280)). Contributed by @justjanne.
* Further improve performance with lots of hidden events ([\element-hq#10353](matrix-org/matrix-react-sdk#10353)). Fixes element-hq#24480. Contributed by @andybalaam.
* Respect user cancelling upload flow by dismissing spinner ([\element-hq#10373](matrix-org/matrix-react-sdk#10373)). Fixes element-hq#24667.
* When starting a DM, the end-to-end encryption status icon does now only appear if the DM can be encrypted ([\element-hq#10394](matrix-org/matrix-react-sdk#10394)). Fixes element-hq#24397.
* Fix `[object Object]` in feedback metadata ([\element-hq#10390](matrix-org/matrix-react-sdk#10390)).
* Fix pinned messages card saying nothing pinned while loading ([\#10385](matrix-org/matrix-react-sdk#10385)). Fixes element-hq#24615.
* Fix import e2e key dialog staying disabled after paste ([\element-hq#10375](matrix-org/matrix-react-sdk#10375)). Fixes element-hq#24818.
* Show all labs even if incompatible, with appropriate tooltip explaining requirements ([\element-hq#10369](matrix-org/matrix-react-sdk#10369)). Fixes element-hq#24813.
* Fix UIFeature.Registration not applying to all paths ([\element-hq#10371](matrix-org/matrix-react-sdk#10371)). Fixes element-hq#24814.
* Clicking on a user pill does now only open the profile in the right panel and no longer navigates to the home view. ([\element-hq#10359](matrix-org/matrix-react-sdk#10359)). Fixes element-hq#24797.
* Fix start DM with pending third party invite ([\element-hq#10347](matrix-org/matrix-react-sdk#10347)). Fixes element-hq#24781.
* Fix long display name overflowing reply tile on IRC layout ([\element-hq#10343](matrix-org/matrix-react-sdk#10343)). Fixes element-hq#24738. Contributed by @luixxiul.
* Display redacted body on ThreadView in the same way as normal messages ([\element-hq#9016](matrix-org/matrix-react-sdk#9016)). Fixes element-hq#24729. Contributed by @luixxiul.
* Handle more edge cases in ACL updates ([\element-hq#10279](matrix-org/matrix-react-sdk#10279)). Contributed by @justjanne.
* Allow parsing png files to fail if thumbnailing is successful ([\element-hq#10308](matrix-org/matrix-react-sdk#10308)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Aggregations A-Message-Editing T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bwindels @jryans @lnicola @anoadragon453 @babolivier