Explicitly check for modifier keydown events before focusing composer #3328

bwindels · 2019-08-20T08:44:41Z

See element-hq/element-web#10390 (comment) for context:

Hmm, I indeed see (Linux, Gnome & Wayland) a keyboard event for just pressing Control on Chromium but not Firefox. If they ctrlKey flag isn't set on this event, it would explain things, but for me this flag is set. I'm adding some extra checks to not refocus when just pressing a modifier key, regardless of the state of the modifier flags. Let's see if that helps.

This is an attempt to fix that issue. See https://www.w3.org/TR/uievents-key/#keys-modifier for key constants.

explicitly check for modifier keydown events

b42b282

bwindels changed the title ~~explicitly check for modifier keydown events~~ Explicitly check for modifier keydown events before focusing composer Aug 20, 2019

bwindels requested a review from a team August 20, 2019 16:07

turt2live approved these changes Aug 20, 2019

View reviewed changes

bwindels merged commit c7c87cc into develop Aug 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Explicitly check for modifier keydown events before focusing composer #3328

Explicitly check for modifier keydown events before focusing composer #3328

bwindels commented Aug 20, 2019 •

edited

Loading

Explicitly check for modifier keydown events before focusing composer #3328

Explicitly check for modifier keydown events before focusing composer #3328

Conversation

bwindels commented Aug 20, 2019 • edited Loading

bwindels commented Aug 20, 2019 •

edited

Loading