Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suggestions to Invite/Create DM dialog #11198

Closed
7 of 10 tasks
bwindels opened this issue Oct 23, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3801
Closed
7 of 10 tasks

Add suggestions to Invite/Create DM dialog #11198

bwindels opened this issue Oct 23, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3801
Assignees
@turt2live
Labels
Z-FTUE Z-FTUE-User-Lists

Comments

@bwindels
Copy link
Contributor

bwindels commented Oct 23, 2019 •
edited by turt2live
Loading

  • suggestions are based on members from rooms you are already in. Members are sorted by (in order):
    • First implementation of suggestions: bwindels/user-suggestions on react-sdk (on the fly)
    • people that have recently mentioned you - anywhere for now
    • people you've recently mentioned - anywhere for now
    • per shared room with a member, weigh by inverted room size, e.g. the smaller the room the higher the member should be.
    • sorted by how many rooms you share with them
    • alphabetically
    • future: look into weighing people more for being selected
  • show 10, add 5 on 'show more'
  • exclude riot bot
  • No suggestions, section not shown

Design at https://app.zeplin.io/project/5c122fa790c5b4241ffa6be7/screen/5d661ab8684fa927fe955d8e
@bwindels bwindels self-assigned this Oct 28, 2019
@bwindels
Copy link
Contributor Author

bwindels commented Oct 28, 2019 •
edited
Loading

did some work on the user suggestions sorting heuristic on the react-sdk branch bwindels/user-suggestions, but parking it now in favour of working on verification over DM.

@bwindels bwindels removed their assignment Oct 28, 2019
This was referenced Nov 25, 2019
Closed
Closed
@nadonomy nadonomy mentioned this issue Nov 28, 2019
Open
@turt2live turt2live self-assigned this Jan 3, 2020
@turt2live turt2live mentioned this issue Jan 4, 2020
Closed
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 4, 2020
@turt2live
Add suggestions for which users to invite to chat
31d5617 
Fixes element-hq/element-web#11198

Note this doesn't implement the entire algorithm in 11198 because it feels too complicated at this stage. Instead, the idea is to review the suggestions closer to when the whole dialog is complete and fix them then: element-hq/element-web#11769

Algorithm for picking members is largely based on db5218e
@turt2live turt2live mentioned this issue Jan 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
Z-FTUE Z-FTUE-User-Lists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add suggestions for which users to invite to chat matrix-org/matrix-react-sdk
3 participants
@bwindels @turt2live @lampholder