Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve/review algorithm for selecting members in invite suggestions #11769

Closed
turt2live opened this issue Jan 4, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3866
Closed

Improve/review algorithm for selecting members in invite suggestions #11769

turt2live opened this issue Jan 4, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3866
Assignees
@turt2live
Labels
Z-FTUE Z-FTUE-User-Lists

Comments

@turt2live
Copy link
Member

See #11198 (comment) for details.

The current theory is that we can get away with 'good' suggestions with a simpler algorithm, though we might want something more complicated or differently simple.

At the moment we score people based on the number of rooms we share with them, inversely (smaller rooms == more likely to suggest those members) then alphabetically. We could track mentions, though that gets a bit complicated for a proof of concept. We'd probably want some generic scoring system for cross-client suggestions being stable, with a bonus for being mentioned "recently".
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 4, 2020
@turt2live
Add suggestions for which users to invite to chat
31d5617 
Fixes element-hq/element-web#11198

Note this doesn't implement the entire algorithm in 11198 because it feels too complicated at this stage. Instead, the idea is to review the suggestions closer to when the whole dialog is complete and fix them then: element-hq/element-web#11769

Algorithm for picking members is largely based on db5218e
@turt2live turt2live mentioned this issue Jan 4, 2020
Merged
@turt2live
Copy link
Member Author

yea, we need to do this before going live with the feature. The suggestions are terrible. I really don't want to start a chat with my dead-for-2-years IoT weather bot.

@bwindels bwindels mentioned this issue Jan 16, 2020
Closed
6 tasks
@turt2live turt2live self-assigned this Jan 17, 2020
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 17, 2020
@turt2live
Score users who have recently spoken higher in invite suggestions
2faa425 
Fixes element-hq/element-web#11769

The algorithm should be documented in the diff as comments.
@turt2live turt2live mentioned this issue Jan 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
Z-FTUE Z-FTUE-User-Lists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Score users who have recently spoken higher in invite suggestions matrix-org/matrix-react-sdk
1 participant
@turt2live