Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references of m.room.aliases in react and js-sdk #12680

Closed
7 tasks
bwindels opened this issue Mar 10, 2020 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2759
Closed
7 tasks
Assignees
Labels
A-Aliases Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Task Tasks for the team like planning

Comments

@bwindels
Copy link
Contributor

bwindels commented Mar 10, 2020

All tasks mentioned in #12337 have been implemented as part of MSC2432, but when searching for m.room.aliases in the code, there are still a few occurrences. I've postponed getting rid of those because we're still in the cross-signing sprint, but afterwards we probably want to clean that up.

m.room.aliases references to remove

matrix-react-sdk:

matrix-js-sdk:

@bwindels bwindels added T-Enhancement T-Task Tasks for the team like planning P1 and removed T-Enhancement labels Mar 10, 2020
@MadLittleMods MadLittleMods added S-Tolerable Low/no impact on users O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P1 labels Oct 14, 2022
@MadLittleMods
Copy link
Contributor

Added a list of references to clean-up to the description.

Looks like a pretty easy technical debt to resolve.

@MadLittleMods MadLittleMods added the Help Wanted Extra attention is needed label Oct 14, 2022
@t3chguy t3chguy self-assigned this Oct 17, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Oct 29, 2022
* Changes the `uploadContent` API, kills off `request` and `browser-request` in favour of `fetch`, removed callback support on a lot of the methods, adds a lot of tests. ([\matrix-org#2719](matrix-org#2719)). Fixes matrix-org#2415 and matrix-org#801.
* Remove deprecated `m.room.aliases` references ([\matrix-org#2759](matrix-org#2759)). Fixes element-hq/element-web#12680.
* Remove node-specific crypto bits, use Node 16's WebCrypto ([\matrix-org#2762](matrix-org#2762)). Fixes matrix-org#2760.
* Export types for MatrixEvent and Room emitted events, and make event handler map types stricter ([\matrix-org#2750](matrix-org#2750)). Contributed by @stas-demydiuk.
* Use even more stable calls to `/room_keys` ([\matrix-org#2746](matrix-org#2746)).
* Upgrade to Olm 3.2.13 which has been repackaged to support Node 18 ([\matrix-org#2744](matrix-org#2744)).
* Fix `power_level_content_override` type ([\matrix-org#2741](matrix-org#2741)).
* Add custom notification handling for MSC3401 call events  ([\matrix-org#2720](matrix-org#2720)).
* Add support for unread thread notifications ([\matrix-org#2726](matrix-org#2726)).
* Load Thread List with server-side assistance (MSC3856) ([\matrix-org#2602](matrix-org#2602)).
* Use stable calls to `/room_keys` ([\matrix-org#2729](matrix-org#2729)). Fixes element-hq/element-web#22839.
* Fix POST data not being passed for registerWithIdentityServer ([\matrix-org#2769](matrix-org#2769)). Fixes matrix-org/element-web-rageshakes#16206.
* Fix IdentityPrefix.V2 containing spurious `/api` ([\matrix-org#2761](matrix-org#2761)). Fixes element-hq/element-web#23505.
* Always send back an httpStatus property if one is known ([\matrix-org#2753](matrix-org#2753)).
* Check for AbortError, not any generic connection error, to avoid tightlooping ([\matrix-org#2752](matrix-org#2752)).
* Correct the dir parameter of MSC3715 ([\matrix-org#2745](matrix-org#2745)). Contributed by @dhenneke.
* Fix sync init when thread unread notif is not supported ([\matrix-org#2739](matrix-org#2739)). Fixes element-hq/element-web#23435.
* Use the correct sender key when checking shared secret ([\matrix-org#2730](matrix-org#2730)). Fixes element-hq/element-web#23374.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Aliases Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants