Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invite with email is failing #23505

Closed
kittykat opened this issue Oct 17, 2022 · 2 comments · Fixed by matrix-org/matrix-js-sdk#2761
Closed

Invite with email is failing #23505

kittykat opened this issue Oct 17, 2022 · 2 comments · Fixed by matrix-org/matrix-js-sdk#2761
Assignees
@t3chguy
Labels
A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression X-Release-Blocker

Comments

@kittykat
Copy link
Contributor

kittykat commented Oct 17, 2022 •
edited
Loading

Steps to reproduce

  1. Go to room list in the right panel
  2. "Invite to this room"
  3. Paste or type in email and press return

Outcome

What did you expect?

User is invited

What happened instead?

Get this error:
Screenshot from 2022-10-17 10-23-08

Issue is happening at least since last Thursday

Browser information

Chromium 106.0.5249.119 (Official Build) Arch Linux (64-bit)

URL for webapp

develop.element.io

Application version

Element version: 3227454-react-1d1860842ef5-js-6245661cd7ae Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

Yes
@kittykat kittykat added T-Defect X-Regression S-Critical Prevents work, causes data loss and/or has no workaround A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 17, 2022
@t3chguy
Copy link
Member

t3chguy commented Oct 17, 2022

This might be a release blocker, needs investigation

2022-10-17T09:20:26.381Z E Error searching identity server:
2022-10-17T09:20:26.381Z E fetch failed: Failed to fetch
ConnectionError: fetch failed: Failed to fetch
    at MatrixHttpApi.requestOtherUrl (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:140945:13)
    at async IdentityAuthClient.registerForToken (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:65811:9)
    at async IdentityAuthClient.getAccessToken (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:65732:15)
    at async InviteDialog_InviteDialog.updateSuggestions (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:137005:25)
2022-10-17T09:20:26.848Z E Error searching identity server:
2022-10-17T09:20:26.848Z E fetch failed: Failed to fetch
ConnectionError: fetch failed: Failed to fetch
    at MatrixHttpApi.requestOtherUrl (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:140945:13)
    at async IdentityAuthClient.registerForToken (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:65811:9)
    at async IdentityAuthClient.getAccessToken (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:65732:15)
    at async InviteDialog_InviteDialog.updateSuggestions (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:137005:25)
2022-10-17T09:20:40.139Z I Update available to 322745464c0e-react-1d1860842ef5-js-be11fa6b5a82 but won't be shown
2022-10-17T09:20:40.383Z I Inviting [email protected]
2022-10-17T09:20:40.576Z E fetch failed: Failed to fetch
ConnectionError: fetch failed: Failed to fetch
    at MatrixHttpApi.requestOtherUrl (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:140945:13)
    at async IdentityAuthClient.registerForToken (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:65811:9)
    at async IdentityAuthClient.getAccessToken (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:65732:15)
    at async MatrixClient.inviteByThreePid (https://develop.element.io/bundles/d1b253ee39346ad2b631/init.js:17800:35)

@t3chguy t3chguy self-assigned this Oct 17, 2022
@t3chguy
Copy link
Member

t3chguy commented Oct 17, 2022

This looks to have been caused by the fetch api migration in the js-sdk wrongly mutating the V2 IdentityPrefix and adding a spurious /api

@t3chguy t3chguy mentioned this issue Oct 17, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Oct 29, 2022
@su-ex
Merge tag 'v21.0.0' into sc
9b20f5c 
* Changes the `uploadContent` API, kills off `request` and `browser-request` in favour of `fetch`, removed callback support on a lot of the methods, adds a lot of tests. ([\matrix-org#2719](matrix-org#2719)). Fixes matrix-org#2415 and matrix-org#801.
* Remove deprecated `m.room.aliases` references ([\matrix-org#2759](matrix-org#2759)). Fixes element-hq/element-web#12680.
* Remove node-specific crypto bits, use Node 16's WebCrypto ([\matrix-org#2762](matrix-org#2762)). Fixes matrix-org#2760.
* Export types for MatrixEvent and Room emitted events, and make event handler map types stricter ([\matrix-org#2750](matrix-org#2750)). Contributed by @stas-demydiuk.
* Use even more stable calls to `/room_keys` ([\matrix-org#2746](matrix-org#2746)).
* Upgrade to Olm 3.2.13 which has been repackaged to support Node 18 ([\matrix-org#2744](matrix-org#2744)).
* Fix `power_level_content_override` type ([\matrix-org#2741](matrix-org#2741)).
* Add custom notification handling for MSC3401 call events  ([\matrix-org#2720](matrix-org#2720)).
* Add support for unread thread notifications ([\matrix-org#2726](matrix-org#2726)).
* Load Thread List with server-side assistance (MSC3856) ([\matrix-org#2602](matrix-org#2602)).
* Use stable calls to `/room_keys` ([\matrix-org#2729](matrix-org#2729)). Fixes element-hq/element-web#22839.
* Fix POST data not being passed for registerWithIdentityServer ([\matrix-org#2769](matrix-org#2769)). Fixes matrix-org/element-web-rageshakes#16206.
* Fix IdentityPrefix.V2 containing spurious `/api` ([\matrix-org#2761](matrix-org#2761)). Fixes element-hq/element-web#23505.
* Always send back an httpStatus property if one is known ([\matrix-org#2753](matrix-org#2753)).
* Check for AbortError, not any generic connection error, to avoid tightlooping ([\matrix-org#2752](matrix-org#2752)).
* Correct the dir parameter of MSC3715 ([\matrix-org#2745](matrix-org#2745)). Contributed by @dhenneke.
* Fix sync init when thread unread notif is not supported ([\matrix-org#2739](matrix-org#2739)). Fixes element-hq/element-web#23435.
* Use the correct sender key when checking shared secret ([\matrix-org#2730](matrix-org#2730)). Fixes element-hq/element-web#23374.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix IdentityPrefix.V2 containing spurious /api matrix-org/matrix-js-sdk
2 participants
@kittykat @t3chguy