Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to search in E2E encrypted rooms without Seshat should error #12896

Closed
ara4n opened this issue Mar 26, 2020 · 7 comments
Closed

Trying to search in E2E encrypted rooms without Seshat should error #12896

ara4n opened this issue Mar 26, 2020 · 7 comments
Labels
A-Indexing Indexing messages via Seshat A-Timeline-Search P1 T-Defect X-Needs-Design Z-Chronic

Comments

@ara4n
Copy link
Member

ara4n commented Mar 26, 2020

Rather than silently failing.

Similarly FilePanel.
@ara4n ara4n added the T-Defect label Mar 26, 2020
@t3chguy
Copy link
Member

t3chguy commented Mar 26, 2020

But what about a room that has unencrypted history?

@ara4n
Copy link
Member Author

ara4n commented Mar 26, 2020

perhaps we put a warning in the search results saying that hits may be missing; go use riot/desktop if you want it to work

@t3chguy
Copy link
Member

t3chguy commented Mar 26, 2020

This was mentioned in #4982 before it got closed

@t3chguy t3chguy mentioned this issue Apr 3, 2020
Closed
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 22, 2020
@turt2live
Take encrypted message search out of labs
fdcdd25 
Fixes element-hq/element-web#13262

This is part of the cross-signing shipping master plan. Known issues relating to this feature are:
* element-hq/element-web#12896
* https://github.com/vector-im/riot-web/issues/12385
* element-hq/element-web#11831
* element-hq/element-web#11155

In theory, these are issues we're comfortable with shipping as we're already enabling it by default. This just makes it easier on everyone by removing the flag (making it still enabled by default).
@turt2live turt2live mentioned this issue Apr 22, 2020
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 22, 2020
@turt2live
Take encrypted message search out of labs
475cea8 
Fixes element-hq/element-web#13262

This is part of the cross-signing shipping master plan. Known issues relating to this feature are:
* element-hq/element-web#12896
* https://github.com/vector-im/riot-web/issues/12385
* element-hq/element-web#11831
* element-hq/element-web#11155

In theory, these are issues we're comfortable with shipping as we're already enabling it by default. This just makes it easier on everyone by removing the flag (making it still enabled by default).
@aaronraimist aaronraimist added the A-Indexing Indexing messages via Seshat label Apr 23, 2020
@t3chguy t3chguy mentioned this issue May 9, 2020
Closed
@dbkr dbkr mentioned this issue Jul 23, 2020
Closed
@bwindels
Copy link
Contributor

Probably needs some design?

@nadonomy nadonomy added the P1 label Sep 16, 2020
@nadonomy
Copy link
Contributor

Some notes from quick internal discussion on solving this:

  • We think it's preferable to advertise the value adds of the desktop app (rather than e.g. not showing the panel at all)
  • If we're advertising the desktop app, we should consider Element admins who don't want to drive traffic to the desktop apps (e.g. private deployments)— should we make a flag to disable this? or can we be smarter with whitelisting domains? etc

@lampholder
Copy link
Member

We're already planning a flag for this: #15184

@lampholder lampholder mentioned this issue Sep 16, 2020
Closed
@turt2live turt2live self-assigned this Sep 16, 2020
@turt2live turt2live removed their assignment Sep 16, 2020
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@turt2live
Add a note to use the desktop builds when seshat isn't available
bfbbf44 
Fixes element-hq/element-web#15184

This is currently temporary design for element-hq/element-web#12896 but does not fix it.
@turt2live turt2live mentioned this issue Sep 16, 2020
Merged
@nadonomy
Copy link
Contributor

Closing as this is now fixed in matrix-org/matrix-react-sdk#5225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Indexing Indexing messages via Seshat A-Timeline-Search P1 T-Defect X-Needs-Design Z-Chronic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@bwindels @jryans @turt2live @ara4n @lampholder @t3chguy @nadonomy @aaronraimist