Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Take encrypted message search out of labs #4467

Merged
merged 4 commits into from
Apr 23, 2020
Merged

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Apr 22, 2020

Fixes element-hq/element-web#13262
Requires element-hq/element-web#13325
Requires element-hq/element-desktop#74

This is part of the cross-signing shipping master plan. Known issues relating to this feature are:

In theory, these are issues we're comfortable with shipping as we're already enabling it by default. This just makes it easier on everyone by removing the flag (making it still enabled by default).

Fixes element-hq/element-web#13262

This is part of the cross-signing shipping master plan. Known issues relating to this feature are:
* element-hq/element-web#12896
* https://github.com/vector-im/riot-web/issues/12385
* element-hq/element-web#11831
* element-hq/element-web#11155

In theory, these are issues we're comfortable with shipping as we're already enabling it by default. This just makes it easier on everyone by removing the flag (making it still enabled by default).
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not close to this thread of development and the related pieces (but assume @jryans is). Good to go based on:

This is part of the cross-signing shipping master plan.

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! There are a few open issues as mentioned, but they aren't serious enough to block release, so we can resolve them down the road.

@jryans jryans merged commit 4a0f228 into develop Apr 23, 2020
@turt2live turt2live deleted the travis/seshat-enable branch April 23, 2020 17:31
turt2live added a commit to element-hq/element-web that referenced this pull request Apr 24, 2020
turt2live added a commit to element-hq/element-desktop that referenced this pull request Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable seshat by default
3 participants