This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 833
Take encrypted message search out of labs #4467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#13262 This is part of the cross-signing shipping master plan. Known issues relating to this feature are: * element-hq/element-web#12896 * https://github.com/vector-im/riot-web/issues/12385 * element-hq/element-web#11831 * element-hq/element-web#11155 In theory, these are issues we're comfortable with shipping as we're already enabling it by default. This just makes it easier on everyone by removing the flag (making it still enabled by default).
turt2live
added a commit
to element-hq/element-web
that referenced
this pull request
Apr 22, 2020
turt2live
added a commit
to element-hq/element-desktop
that referenced
this pull request
Apr 22, 2020
nadonomy
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not close to this thread of development and the related pieces (but assume @jryans is). Good to go based on:
This is part of the cross-signing shipping master plan.
jryans
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me! There are a few open issues as mentioned, but they aren't serious enough to block release, so we can resolve them down the road.
turt2live
added a commit
to element-hq/element-web
that referenced
this pull request
Apr 24, 2020
turt2live
added a commit
to element-hq/element-desktop
that referenced
this pull request
Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#13262
Requires element-hq/element-web#13325
Requires element-hq/element-desktop#74
This is part of the cross-signing shipping master plan. Known issues relating to this feature are:
In theory, these are issues we're comfortable with shipping as we're already enabling it by default. This just makes it easier on everyone by removing the flag (making it still enabled by default).