Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relations are not sent to widgets suddenly #19062

Closed
turt2live opened this issue Sep 15, 2021 · 1 comment · Fixed by matrix-org/matrix-js-sdk#1938
Closed

Relations are not sent to widgets suddenly #19062

turt2live opened this issue Sep 15, 2021 · 1 comment · Fixed by matrix-org/matrix-js-sdk#1938
Assignees
@turt2live
Labels
A-Widgets O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist X-Regression Z-TravisR

Comments

@turt2live
Copy link
Member

turt2live commented Sep 15, 2021 •
edited by MadLittleMods
Loading

Relations are not sent to widgets suddenly

As discussed at https://matrix.to/#/!rDkLtgRQarvieuFHBA:t2l.io/$fdL59-H_05nq7WeINE0CKMeVtFOXMjUupozOjOkyrSQ?via=matrix.org&via=vector.modular.im&via=nordgedanken.dev
@turt2live turt2live self-assigned this Sep 15, 2021
@turt2live turt2live added A-Widgets O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist X-Needs-Info This issue is blocked awaiting information from the reporter X-Regression X-Release-Blocker Z-TravisR labels Sep 15, 2021
@MadLittleMods MadLittleMods mentioned this issue Sep 15, 2021
Merged
@turt2live turt2live removed X-Needs-Info This issue is blocked awaiting information from the reporter X-Release-Blocker labels Sep 18, 2021
@turt2live
Copy link
Member Author

This further got narrowed down to an issue where encrypted events specifically do not have m.relates_to data - turns out this is because it's not encrypted (usually), so the js-sdk clobbers the content key with the decrypted copy, which doesn't have the field.

turt2live added a commit to matrix-org/matrix-js-sdk that referenced this issue Sep 18, 2021
@turt2live
Ensure unencrypted fields get exposed by getEffectiveEvent()
9f42647 
Fixes element-hq/element-web#19062
@turt2live turt2live mentioned this issue Sep 18, 2021
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Oct 16, 2021
@su-ex
Merge tag 'v14.0.1' into sc
29fd130 
* Support for call upgrades. `setLocalVideoMuted()` and `setMicrophoneMuted()` are now `async` and return the new mute state ([\matrix-org#1827](matrix-org#1827)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Implement file versioning for tree spaces ([\matrix-org#1952](matrix-org#1952)).
* Allow answering calls without audio/video ([\matrix-org#1950](matrix-org#1950)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add `bound` to `IThreepid` ([\matrix-org#1941](matrix-org#1941)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add `trusted_locally` to `TrustInfo` ([\matrix-org#1942](matrix-org#1942)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix incorrect return value type in getJoinedRooms() ([\matrix-org#1959](matrix-org#1959)). Contributed by [psrpinto](https://github.com/psrpinto).
* Make sure to set `callLengthInterval` only once ([\matrix-org#1958](matrix-org#1958)). Fixes element-hq/element-web#19221 and element-hq/element-web#19221. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix event partitioning from non threading ready clients ([\matrix-org#1948](matrix-org#1948)).
* Ensure unencrypted fields get exposed by getEffectiveEvent() ([\matrix-org#1938](matrix-org#1938)). Fixes element-hq/element-web#19062 and element-hq/element-web#19062.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Widgets O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist X-Regression Z-TravisR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure unencrypted fields get exposed by getEffectiveEvent() matrix-org/matrix-js-sdk
1 participant
@turt2live