Support for call upgrades #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBrandner
force-pushed
the
feature/call-upgrades
branch
from
cf07991
to
21236ef
Compare
SimonBrandner
force-pushed
the
feature/call-upgrades
branch
4 times, most recently
from
e292e6f
to
9f9524e
Compare
SimonBrandner
force-pushed
the
feature/call-upgrades
branch
4 times, most recently
from
4c9f2e5
to
03f8137
Compare
Signed-off-by: Šimon Brandner <[email protected]>
…t track combinations Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
feature/call-upgrades
branch
from
03f8137
to
695248d
Compare
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
feature/call-upgrades
branch
from
695248d
to
a4cacbc
Compare
SimonBrandner
changed the title
turt2live
reviewed
Sep 18, 2021
There was a problem hiding this comment.
otherwise looks good! Not sure if we want to squeeze this into the RC or if we should delay it. Very keen not to stick it into the release just because we have another breaking change: version numbers are relatively free, and we can afford back-to-back breaking releases.
Co-authored-by: Travis Ralston <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
…ner/matrix-js-sdk into feature/call-upgrades
Yeah, makes sense, let's wait a bit 👍 |
turt2live
reviewed
Sep 20, 2021
Signed-off-by: Šimon Brandner <[email protected]>
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Oct 16, 2021
* Support for call upgrades. `setLocalVideoMuted()` and `setMicrophoneMuted()` are now `async` and return the new mute state ([\matrix-org#1827](matrix-org#1827)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Implement file versioning for tree spaces ([\matrix-org#1952](matrix-org#1952)). * Allow answering calls without audio/video ([\matrix-org#1950](matrix-org#1950)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Add `bound` to `IThreepid` ([\matrix-org#1941](matrix-org#1941)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Add `trusted_locally` to `TrustInfo` ([\matrix-org#1942](matrix-org#1942)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix incorrect return value type in getJoinedRooms() ([\matrix-org#1959](matrix-org#1959)). Contributed by [psrpinto](https://github.com/psrpinto). * Make sure to set `callLengthInterval` only once ([\matrix-org#1958](matrix-org#1958)). Fixes element-hq/element-web#19221 and element-hq/element-web#19221. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix event partitioning from non threading ready clients ([\matrix-org#1948](matrix-org#1948)). * Ensure unencrypted fields get exposed by getEffectiveEvent() ([\matrix-org#1938](matrix-org#1938)). Fixes element-hq/element-web#19062 and element-hq/element-web#19062.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: enhancement
Requires matrix-org/matrix-react-sdk#6547
Notes: Support for call upgrades.
setLocalVideoMuted()andsetMicrophoneMuted()are nowasyncand return the new mute stateHere's what your changelog entry will look like:
🚨 BREAKING CHANGES
setLocalVideoMuted()andsetMicrophoneMuted()are nowasyncand return the new mute state (#1827). Contributed by SimonBrandner.