Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regular reply in non-threads mode vanished in threads mode #19587

Closed
Tracked by #3
jryans opened this issue Nov 2, 2021 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2011
Closed
Tracked by #3

Regular reply in non-threads mode vanished in threads mode #19587

jryans opened this issue Nov 2, 2021 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2011
Assignees
@germain-gg
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Milestone
App team 1.9.5

Comments

@jryans
Copy link
Collaborator

jryans commented Nov 2, 2021

Steps to reproduce

  1. Disable threads in Labs
  2. Reply to an existing reply, creating a nested reply (nested may or may not matter)
  3. Enable threads in Labs
  4. Try to find your reply

Outcome

What did you expect?

I expected my reply to exist somewhere, either in the main timeline or in a thread.

What happened instead?

My regular reply (not a thread reply) disappeared from the main timeline. It did however appear in the thread summary view attached to the root (grandparent) of my reply. When I then click on that thread to try to view it, only the thread root appears in the right panel. My message is not shown.

Operating system

macOS

Browser information

Firefox 96

URL for webapp

develop.element.io

Application version

Element version: c52905f-react-351c426d2a39-js-a7cc1ae630d0 Olm version: 3.2.3

Homeserver

matrix.org

Will you send logs?

No
@jryans jryans added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Threads labels Nov 2, 2021
@germain-gg germain-gg self-assigned this Nov 3, 2021
@germain-gg germain-gg added this to the App team 1.9.5 milestone Nov 3, 2021
@dkasak dkasak mentioned this issue Nov 3, 2021
Closed
This was referenced Nov 3, 2021
Merged
Merged
Closed
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Nov 24, 2021
@su-ex
Merge tag 'v15.1.1' into sc
b3aa5e5 
* Fix edit history being broken after editing an unencrypted event with an encrypted event ([\matrix-org#2013](matrix-org#2013)). Fixes element-hq/element-web#19651 and element-hq/element-web#19651. Contributed by @aaronraimist.
* Make events pagination responses parse threads ([\matrix-org#2011](matrix-org#2011)). Fixes element-hq/element-web#19587 and element-hq/element-web#19587.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
App team 1.9.5
Development

Successfully merging a pull request may close this issue.

Make events pagination responses parse threads matrix-org/matrix-js-sdk
2 participants
@jryans @germain-gg