Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling turns on video without participant consent. #20212

Closed
viasux opened this issue Dec 15, 2021 · 8 comments · Fixed by #20234
Closed

Calling turns on video without participant consent. #20212

viasux opened this issue Dec 15, 2021 · 8 comments · Fixed by #20234
Labels
A-Jitsi O-Occasional Affects or can be seen by some users regularly or most users rarely Privacy S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@viasux
Copy link

viasux commented Dec 15, 2021

Steps to reproduce

  1. In a group chat, start or join a jitsi call (even when clicking the "voice call" button).
  2. Your camera is now on, without consent or warning, and visible to anyone connecting to your call.

Outcome

What did you expect?

I expected that there would at least be a warning if it were to turn on, and if anything, hitting "voice call" wouldn't have turned on my camera.

What happened instead?

My camera was immediately turned on.

Operating system

No response

Application version

Element version: 1.9.7 Olm version: 3.2.8

How did you install the app?

https://community.chocolatey.org/packages/element-desktop

Homeserver

yiff.social

Will you send logs?

No

@SimonBrandner SimonBrandner added A-Jitsi O-Occasional Affects or can be seen by some users regularly or most users rarely Privacy S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Dec 15, 2021
@novocaine novocaine added S-Critical Prevents work, causes data loss and/or has no workaround and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Dec 16, 2021
@novocaine
Copy link
Contributor

This is critical if it's happening after pressing voice call.

@viasux
Copy link
Author

viasux commented Dec 16, 2021

Just realized i didnt mention this was through "jitsi" calling (which is default for group chats), but i believe ive had the same behavior with native calls too.

I'm surprised this hasn't been reported, as this is the behavior for everyone I've heard of when using jitsi, I always warn people that it happens.

@viasux
Copy link
Author

viasux commented Dec 16, 2021

Just realized i didnt mention this was through "jitsi" calling (which is default for group chats), but i believe ive had the same behavior with native calls too.

I'm surprised this hasn't been reported, as this is the behavior for everyone I've heard of when using jitsi, I always warn people that it happens.

Alright I did some testing and I suppose it doesn't happen nearly as often as I have remembered (it did happen once out of ~10 tries & it happened earlier today when I submitted this report), although I believe that answering the call (not initiating it) almost always turns your camera on.. However, in another room, calling started with a completely different prompt which showed settings to enable/disable video and audio devices before entering the call. Not sure why there's so much inconsistency here. Sorry if it's confusing!

@viasux
Copy link
Author

viasux commented Dec 16, 2021

image

@novocaine
Copy link
Contributor

However, in another room, calling started with a completely different prompt which showed settings to enable/disable video and audio devices before entering the call.

This is the case in newer versions of Jitsi. AFAICT, the Jitsi instance can be set in Element config or by the homeserver; if neither are set, it falls back to https://jitsi.riot.im/ which is using an older Jitsi version without that feature.

@novocaine
Copy link
Contributor

It makes some sense that particular Jitsi instances would be remembering your prior config based on cookies. I've created a PR that turns off the camera for voice calls; we were not passing the param to the Jitsi SDK for some reason.

@viasux
Copy link
Author

viasux commented Dec 17, 2021

It makes some sense that particular Jitsi instances would be remembering your prior config based on cookies. I've created a PR that turns off the camera for voice calls; we were not passing the param to the Jitsi SDK for some reason.

If other jitsi instances could just ignore this sdk parameter (since it seems youre saying the camera is not disabled or enabled by element), that would pose another issue, right? Couldnt someone just make a modified (malicious) jitsi widget which silently records your video?

@novocaine
Copy link
Contributor

novocaine commented Dec 17, 2021

If other jitsi instances could just ignore this sdk parameter (since it seems youre saying the camera is not disabled or enabled by element), that would pose another issue, right? Couldnt someone just make a modified (malicious) jitsi widget which silently records your video?

The Jitsi widget code is part of your local copy of Element, which where I've just fixed the bug. Other people can't make you run arbitrary widget code.

Note that the PR should force the camera off for voice calls and override the prior config.

su-ex added a commit to SchildiChat/element-web that referenced this issue Jan 17, 2022
* Add permission dropdown for sending reactions ([\element-hq#7492](matrix-org/matrix-react-sdk#7492)). Fixes element-hq#20450.
* Ship maximised widgets and remove feature flag ([\element-hq#7509](matrix-org/matrix-react-sdk#7509)).
* Properly maintain aspect ratio of inline images ([\element-hq#7503](matrix-org/matrix-react-sdk#7503)).
* Add zoom buttons to the location view ([\element-hq#7482](matrix-org/matrix-react-sdk#7482)).
* Remove bubble from around location events ([\element-hq#7459](matrix-org/matrix-react-sdk#7459)). Fixes element-hq#20323.
* Disable "Publish this room" option in invite only rooms ([\element-hq#7441](matrix-org/matrix-react-sdk#7441)). Fixes element-hq#6596. Contributed by @aaronraimist.
* Give secret key field an `id` ([\element-hq#7489](matrix-org/matrix-react-sdk#7489)). Fixes element-hq#20390. Contributed by @SimonBrandner.
* Display a tooltip when you hover over a location ([\element-hq#7472](matrix-org/matrix-react-sdk#7472)).
* Open map in a dialog when it is clicked ([\element-hq#7465](matrix-org/matrix-react-sdk#7465)).
* a11y - wrap notification level radios in fieldsets ([\element-hq#7471](matrix-org/matrix-react-sdk#7471)).
* Wrap inputs in fieldsets in Space visibility settings ([\element-hq#7350](matrix-org/matrix-react-sdk#7350)).
* History based navigation with new right panel store ([\element-hq#7398](matrix-org/matrix-react-sdk#7398)). Fixes element-hq#19686 element-hq#19660 and element-hq#19634.
* Associate room alias warning with public option in settings ([\element-hq#7430](matrix-org/matrix-react-sdk#7430)).
* Disable quick reactions button when no permissions ([\element-hq#7412](matrix-org/matrix-react-sdk#7412)). Fixes element-hq#20270.
* Allow opening a map view in OpenStreetMap ([\element-hq#7428](matrix-org/matrix-react-sdk#7428)).
* Display the user's avatar when they shared their location ([\element-hq#7424](matrix-org/matrix-react-sdk#7424)).
* Remove the Forward and Share buttons for location messages only ([\element-hq#7423](matrix-org/matrix-react-sdk#7423)).
* Add configuration to disable relative date markers in timeline ([\element-hq#7405](matrix-org/matrix-react-sdk#7405)).
* Space preferences for whether or not you see DMs in a Space ([\element-hq#7250](matrix-org/matrix-react-sdk#7250)). Fixes element-hq#19529 and element-hq#19955.
* Have LocalEchoWrapper emit updates so the app can react faster ([\#7358](matrix-org/matrix-react-sdk#7358)). Fixes element-hq#19749.
* Use semantic heading on dialog component ([\element-hq#7383](matrix-org/matrix-react-sdk#7383)).
* Add `/jumptodate` slash command ([\element-hq#7372](matrix-org/matrix-react-sdk#7372)). Fixes element-hq#7677.
* Update room context menu copy ([\element-hq#7361](matrix-org/matrix-react-sdk#7361)). Fixes element-hq#20133.
* Use lazy rendering in the AddExistingToSpaceDialog ([\element-hq#7369](matrix-org/matrix-react-sdk#7369)). Fixes element-hq#18784.
* Tweak FacePile tooltip to include whether or not you are included ([\element-hq#7367](matrix-org/matrix-react-sdk#7367)). Fixes element-hq#17278.
* Ensure group audio-only calls don't switch on the webcam on join ([\element-hq#20234](element-hq#20234)). Fixes element-hq#20212.
* Fix wrongly wrapping code blocks, breaking line numbers ([\element-hq#7507](matrix-org/matrix-react-sdk#7507)). Fixes element-hq#20316.
* Set header buttons to no phase when right panel is closed ([\element-hq#7506](matrix-org/matrix-react-sdk#7506)).
* Fix active Jitsi calls (and other active widgets) not being visible on screen, by showing them in PiP if they are not visible in any other container ([\element-hq#7435](matrix-org/matrix-react-sdk#7435)). Fixes element-hq#15169 and element-hq#20275.
* Fix layout of message bubble preview in settings ([\element-hq#7497](matrix-org/matrix-react-sdk#7497)).
* Prevent mutations of js-sdk owned objects as it breaks accountData ([\element-hq#7504](matrix-org/matrix-react-sdk#7504)). Fixes matrix-org/element-web-rageshakes#7822.
* fallback properly with pluralized strings ([\element-hq#7495](matrix-org/matrix-react-sdk#7495)). Fixes element-hq#20455.
* Consider continuations when resolving whether a tile is last in section ([\element-hq#7461](matrix-org/matrix-react-sdk#7461)). Fixes element-hq#20368 and element-hq#20369.
* Fix read receipts and sent indicators for bubble layout ([\element-hq#7460](matrix-org/matrix-react-sdk#7460)). Fixes element-hq#18298 and element-hq#20345.
* null-guard dataset mxTheme to prevent html exports from exploding ([\element-hq#7493](matrix-org/matrix-react-sdk#7493)). Fixes element-hq#20453.
* Fix avatar container overlapping give feedback cta ([\element-hq#7491](matrix-org/matrix-react-sdk#7491)). Fixes matrix-org/element-web-rageshakes#7987.
* Fix jump to bottom button working when on a permalink ([\element-hq#7494](matrix-org/matrix-react-sdk#7494)). Fixes element-hq#19813.
* Remove the Description from the location picker ([\element-hq#7485](matrix-org/matrix-react-sdk#7485)).
* Fix look of the untrusted device dialog ([\#7487](matrix-org/matrix-react-sdk#7487)). Fixes element-hq#20447. Contributed by @SimonBrandner.
* Hide maximise button in the sticker picker  ([\element-hq#7488](matrix-org/matrix-react-sdk#7488)). Fixes element-hq#20443. Contributed by @SimonBrandner.
* Fix space ordering to match newer spec ([\element-hq#7481](matrix-org/matrix-react-sdk#7481)).
* Fix typing notification colors ([\element-hq#7490](matrix-org/matrix-react-sdk#7490)). Fixes element-hq#20144. Contributed by @SimonBrandner.
* fix fallback for pluralized strings ([\element-hq#7480](matrix-org/matrix-react-sdk#7480)). Fixes element-hq#20426.
* Fix right panel soft crashes chat rooms ([\element-hq#7479](matrix-org/matrix-react-sdk#7479)). Fixes element-hq#20433.
* update yarn.lock and i18n ([\element-hq#7476](matrix-org/matrix-react-sdk#7476)). Fixes element-hq#20426 and element-hq#20423.
* Don't send typing notification when restoring composer draft ([\element-hq#7477](matrix-org/matrix-react-sdk#7477)). Fixes element-hq#20424.
* Fix room joining spinner being incorrect if you change room mid-join ([\element-hq#7473](matrix-org/matrix-react-sdk#7473)).
* Only return the approved widget capabilities instead of accepting all requested capabilities ([\element-hq#7454](matrix-org/matrix-react-sdk#7454)). Contributed by @dhenneke.
* Fix quoting messages from the search view ([\element-hq#7466](matrix-org/matrix-react-sdk#7466)). Fixes element-hq#20353.
* Attribute fallback i18n strings with lang attribute ([\element-hq#7323](matrix-org/matrix-react-sdk#7323)).
* Fix spotlight cmd-k wrongly expanding left panel ([\element-hq#7463](matrix-org/matrix-react-sdk#7463)). Fixes element-hq#20399.
* Fix room_id check when adding user widgets ([\element-hq#7448](matrix-org/matrix-react-sdk#7448)). Fixes element-hq#19382. Contributed by @bink.
* Add new line in settings label ([\element-hq#7451](matrix-org/matrix-react-sdk#7451)). Fixes element-hq#20365.
* Fix handling incoming redactions in EventIndex ([\element-hq#7443](matrix-org/matrix-react-sdk#7443)). Fixes element-hq#19326.
* Fix room alias address isn't checked for validity before being shown as added ([\element-hq#7107](matrix-org/matrix-react-sdk#7107)). Fixes element-hq#19609. Contributed by @Palid.
* Call view accessibility fixes ([\element-hq#7439](matrix-org/matrix-react-sdk#7439)). Fixes element-hq#18516.
* Fix offscreen canvas breaking with split-brained firefox support ([\element-hq#7440](matrix-org/matrix-react-sdk#7440)).
* Removed red shield in forwarding preview. ([\element-hq#7447](matrix-org/matrix-react-sdk#7447)). Contributed by @ankur12-1610.
* Wrap status message ([\element-hq#7325](matrix-org/matrix-react-sdk#7325)). Fixes element-hq#20092. Contributed by @SimonBrandner.
* Move hideSender logic into state so it causes re-render ([\element-hq#7413](matrix-org/matrix-react-sdk#7413)). Fixes element-hq#18448.
* Fix dialpad positioning ([\element-hq#7446](matrix-org/matrix-react-sdk#7446)). Fixes element-hq#20175. Contributed by @SimonBrandner.
* Hide non-functional list options on Suggested sublist ([\element-hq#7410](matrix-org/matrix-react-sdk#7410)). Fixes element-hq#20252.
* Fix width overflow in mini composer overflow menu ([\element-hq#7411](matrix-org/matrix-react-sdk#7411)). Fixes element-hq#20263.
* Fix being wrongly sent to Home space when creating/joining/leaving rooms ([\element-hq#7418](matrix-org/matrix-react-sdk#7418)). Fixes matrix-org/element-web-rageshakes#7331 element-hq#20246 and element-hq#20240.
* Fix HTML Export where the data-mx-theme is `Light` not `light` ([\element-hq#7415](matrix-org/matrix-react-sdk#7415)).
* Don't disable username/password fields whilst doing wk-lookup ([\element-hq#7438](matrix-org/matrix-react-sdk#7438)). Fixes element-hq#20121.
* Prevent keyboard propagation out of context menus ([\element-hq#7437](matrix-org/matrix-react-sdk#7437)). Fixes element-hq#20317.
* Fix nulls leaking into geo urls ([\element-hq#7433](matrix-org/matrix-react-sdk#7433)).
* Fix zIndex of peristent apps in miniMode ([\element-hq#7429](matrix-org/matrix-react-sdk#7429)).
* Space panel should watch spaces for space name changes ([\element-hq#7432](matrix-org/matrix-react-sdk#7432)).
* Fix list formatting alternating on edit ([\element-hq#7422](matrix-org/matrix-react-sdk#7422)). Fixes element-hq#20073. Contributed by @renancleyson-dev.
* Don't show `Testing small changes` without UIFeature.Feedback ([\element-hq#7427](matrix-org/matrix-react-sdk#7427)). Fixes element-hq#20298.
* Fix invisible toggle space panel button ([\element-hq#7426](matrix-org/matrix-react-sdk#7426)). Fixes element-hq#20279.
* Fix legacy breadcrumbs wrongly showing up ([\element-hq#7425](matrix-org/matrix-react-sdk#7425)).
* Space Panel use SettingsStore instead of SpaceStore as source of truth ([\element-hq#7404](matrix-org/matrix-react-sdk#7404)). Fixes element-hq#20250.
* Fix inline code block nowrap issue ([\element-hq#7406](matrix-org/matrix-react-sdk#7406)).
* Fix notification badge for All Rooms space ([\element-hq#7401](matrix-org/matrix-react-sdk#7401)). Fixes element-hq#20229.
* Show error if could not load space hierarchy ([\element-hq#7399](matrix-org/matrix-react-sdk#7399)). Fixes element-hq#20221.
* Increase gap between ELS and the subsequent event to prevent overlap ([\element-hq#7391](matrix-org/matrix-react-sdk#7391)). Fixes element-hq#18319.
* Fix list of members in space preview ([\element-hq#7356](matrix-org/matrix-react-sdk#7356)). Fixes element-hq#19781.
* Fix sizing of e2e shield in bubble layout ([\element-hq#7394](matrix-org/matrix-react-sdk#7394)). Fixes element-hq#19090.
* Fix bubble radius wrong when followed by a state event from same user ([\element-hq#7393](matrix-org/matrix-react-sdk#7393)). Fixes element-hq#18982.
* Fix alignment between ELS and Events in bubble layout ([\element-hq#7392](matrix-org/matrix-react-sdk#7392)). Fixes element-hq#19652 and element-hq#19057.
* Don't include the accuracy parameter in location events if accuracy could not be determined. ([\element-hq#7375](matrix-org/matrix-react-sdk#7375)).
* Make compact layout only apply to Modern layout ([\element-hq#7382](matrix-org/matrix-react-sdk#7382)). Fixes element-hq#18412.
* Pin qrcode to fix e2e verification bug ([\element-hq#7378](matrix-org/matrix-react-sdk#7378)). Fixes element-hq#20188.
* Add internationalisation to progress strings in room export dialog ([\element-hq#7385](matrix-org/matrix-react-sdk#7385)). Fixes element-hq#20208.
* Prevent escape to cancel edit from also scrolling to bottom ([\element-hq#7380](matrix-org/matrix-react-sdk#7380)). Fixes element-hq#20182.
* Fix narrow mode composer buttons for polls labs ([\element-hq#7386](matrix-org/matrix-react-sdk#7386)). Fixes element-hq#20067.
* Fix useUserStatusMessage exploding on unknown user ([\element-hq#7365](matrix-org/matrix-react-sdk#7365)).
* Fix room join spinner in room list header ([\element-hq#7364](matrix-org/matrix-react-sdk#7364)). Fixes element-hq#20139.
* Fix room search sometimes not opening spotlight ([\element-hq#7363](matrix-org/matrix-react-sdk#7363)). Fixes matrix-org/element-web-rageshakes#7288.
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Jan 17, 2022
* Add permission dropdown for sending reactions ([\#7492](matrix-org/matrix-react-sdk#7492)). Fixes element-hq/element-web#20450.
* Ship maximised widgets and remove feature flag ([\#7509](matrix-org/matrix-react-sdk#7509)).
* Properly maintain aspect ratio of inline images ([\#7503](matrix-org/matrix-react-sdk#7503)).
* Add zoom buttons to the location view ([\#7482](matrix-org/matrix-react-sdk#7482)).
* Remove bubble from around location events ([\#7459](matrix-org/matrix-react-sdk#7459)). Fixes element-hq/element-web#20323.
* Disable "Publish this room" option in invite only rooms ([\#7441](matrix-org/matrix-react-sdk#7441)). Fixes element-hq/element-web#6596. Contributed by @aaronraimist.
* Give secret key field an `id` ([\#7489](matrix-org/matrix-react-sdk#7489)). Fixes element-hq/element-web#20390. Contributed by @SimonBrandner.
* Display a tooltip when you hover over a location ([\#7472](matrix-org/matrix-react-sdk#7472)).
* Open map in a dialog when it is clicked ([\#7465](matrix-org/matrix-react-sdk#7465)).
* a11y - wrap notification level radios in fieldsets ([\#7471](matrix-org/matrix-react-sdk#7471)).
* Wrap inputs in fieldsets in Space visibility settings ([\#7350](matrix-org/matrix-react-sdk#7350)).
* History based navigation with new right panel store ([\#7398](matrix-org/matrix-react-sdk#7398)). Fixes element-hq/element-web#19686 element-hq/element-web#19660 and element-hq/element-web#19634.
* Associate room alias warning with public option in settings ([\#7430](matrix-org/matrix-react-sdk#7430)).
* Disable quick reactions button when no permissions ([\#7412](matrix-org/matrix-react-sdk#7412)). Fixes element-hq/element-web#20270.
* Allow opening a map view in OpenStreetMap ([\#7428](matrix-org/matrix-react-sdk#7428)).
* Display the user's avatar when they shared their location ([\#7424](matrix-org/matrix-react-sdk#7424)).
* Remove the Forward and Share buttons for location messages only ([\#7423](matrix-org/matrix-react-sdk#7423)).
* Add configuration to disable relative date markers in timeline ([\#7405](matrix-org/matrix-react-sdk#7405)).
* Space preferences for whether or not you see DMs in a Space ([\#7250](matrix-org/matrix-react-sdk#7250)). Fixes element-hq/element-web#19529 and element-hq/element-web#19955.
* Have LocalEchoWrapper emit updates so the app can react faster ([\#7358](matrix-org/matrix-react-sdk#7358)). Fixes element-hq/element-web#19749.
* Use semantic heading on dialog component ([\#7383](matrix-org/matrix-react-sdk#7383)).
* Add `/jumptodate` slash command ([\#7372](matrix-org/matrix-react-sdk#7372)). Fixes element-hq/element-web#7677.
* Update room context menu copy ([\#7361](matrix-org/matrix-react-sdk#7361)). Fixes element-hq/element-web#20133.
* Use lazy rendering in the AddExistingToSpaceDialog ([\#7369](matrix-org/matrix-react-sdk#7369)). Fixes element-hq/element-web#18784.
* Tweak FacePile tooltip to include whether or not you are included ([\#7367](matrix-org/matrix-react-sdk#7367)). Fixes element-hq/element-web#17278.
* Ensure group audio-only calls don't switch on the webcam on join ([\#20234](element-hq/element-web#20234)). Fixes element-hq/element-web#20212.
* Fix wrongly wrapping code blocks, breaking line numbers ([\#7507](matrix-org/matrix-react-sdk#7507)). Fixes element-hq/element-web#20316.
* Set header buttons to no phase when right panel is closed ([\#7506](matrix-org/matrix-react-sdk#7506)).
* Fix active Jitsi calls (and other active widgets) not being visible on screen, by showing them in PiP if they are not visible in any other container ([\#7435](matrix-org/matrix-react-sdk#7435)). Fixes element-hq/element-web#15169 and element-hq/element-web#20275.
* Fix layout of message bubble preview in settings ([\#7497](matrix-org/matrix-react-sdk#7497)).
* Prevent mutations of js-sdk owned objects as it breaks accountData ([\#7504](matrix-org/matrix-react-sdk#7504)). Fixes matrix-org/element-web-rageshakes#7822.
* fallback properly with pluralized strings ([\#7495](matrix-org/matrix-react-sdk#7495)). Fixes element-hq/element-web#20455.
* Consider continuations when resolving whether a tile is last in section ([\#7461](matrix-org/matrix-react-sdk#7461)). Fixes element-hq/element-web#20368 and element-hq/element-web#20369.
* Fix read receipts and sent indicators for bubble layout ([\#7460](matrix-org/matrix-react-sdk#7460)). Fixes element-hq/element-web#18298 and element-hq/element-web#20345.
* null-guard dataset mxTheme to prevent html exports from exploding ([\#7493](matrix-org/matrix-react-sdk#7493)). Fixes element-hq/element-web#20453.
* Fix avatar container overlapping give feedback cta ([\#7491](matrix-org/matrix-react-sdk#7491)). Fixes matrix-org/element-web-rageshakes#7987.
* Fix jump to bottom button working when on a permalink ([\#7494](matrix-org/matrix-react-sdk#7494)). Fixes element-hq/element-web#19813.
* Remove the Description from the location picker ([\#7485](matrix-org/matrix-react-sdk#7485)).
* Fix look of the untrusted device dialog ([\#7487](matrix-org/matrix-react-sdk#7487)). Fixes element-hq/element-web#20447. Contributed by @SimonBrandner.
* Hide maximise button in the sticker picker  ([\#7488](matrix-org/matrix-react-sdk#7488)). Fixes element-hq/element-web#20443. Contributed by @SimonBrandner.
* Fix space ordering to match newer spec ([\#7481](matrix-org/matrix-react-sdk#7481)).
* Fix typing notification colors ([\#7490](matrix-org/matrix-react-sdk#7490)). Fixes element-hq/element-web#20144. Contributed by @SimonBrandner.
* fix fallback for pluralized strings ([\#7480](matrix-org/matrix-react-sdk#7480)). Fixes element-hq/element-web#20426.
* Fix right panel soft crashes chat rooms ([\#7479](matrix-org/matrix-react-sdk#7479)). Fixes element-hq/element-web#20433.
* update yarn.lock and i18n ([\#7476](matrix-org/matrix-react-sdk#7476)). Fixes element-hq/element-web#20426 and element-hq/element-web#20423.
* Don't send typing notification when restoring composer draft ([\#7477](matrix-org/matrix-react-sdk#7477)). Fixes element-hq/element-web#20424.
* Fix room joining spinner being incorrect if you change room mid-join ([\#7473](matrix-org/matrix-react-sdk#7473)).
* Only return the approved widget capabilities instead of accepting all requested capabilities ([\#7454](matrix-org/matrix-react-sdk#7454)). Contributed by @dhenneke.
* Fix quoting messages from the search view ([\#7466](matrix-org/matrix-react-sdk#7466)). Fixes element-hq/element-web#20353.
* Attribute fallback i18n strings with lang attribute ([\#7323](matrix-org/matrix-react-sdk#7323)).
* Fix spotlight cmd-k wrongly expanding left panel ([\#7463](matrix-org/matrix-react-sdk#7463)). Fixes element-hq/element-web#20399.
* Fix room_id check when adding user widgets ([\#7448](matrix-org/matrix-react-sdk#7448)). Fixes element-hq/element-web#19382. Contributed by @bink.
* Add new line in settings label ([\#7451](matrix-org/matrix-react-sdk#7451)). Fixes element-hq/element-web#20365.
* Fix handling incoming redactions in EventIndex ([\#7443](matrix-org/matrix-react-sdk#7443)). Fixes element-hq/element-web#19326.
* Fix room alias address isn't checked for validity before being shown as added ([\#7107](matrix-org/matrix-react-sdk#7107)). Fixes element-hq/element-web#19609. Contributed by @Palid.
* Call view accessibility fixes ([\#7439](matrix-org/matrix-react-sdk#7439)). Fixes element-hq/element-web#18516.
* Fix offscreen canvas breaking with split-brained firefox support ([\#7440](matrix-org/matrix-react-sdk#7440)).
* Removed red shield in forwarding preview. ([\#7447](matrix-org/matrix-react-sdk#7447)). Contributed by @ankur12-1610.
* Wrap status message ([\#7325](matrix-org/matrix-react-sdk#7325)). Fixes element-hq/element-web#20092. Contributed by @SimonBrandner.
* Move hideSender logic into state so it causes re-render ([\#7413](matrix-org/matrix-react-sdk#7413)). Fixes element-hq/element-web#18448.
* Fix dialpad positioning ([\#7446](matrix-org/matrix-react-sdk#7446)). Fixes element-hq/element-web#20175. Contributed by @SimonBrandner.
* Hide non-functional list options on Suggested sublist ([\#7410](matrix-org/matrix-react-sdk#7410)). Fixes element-hq/element-web#20252.
* Fix width overflow in mini composer overflow menu ([\#7411](matrix-org/matrix-react-sdk#7411)). Fixes element-hq/element-web#20263.
* Fix being wrongly sent to Home space when creating/joining/leaving rooms ([\#7418](matrix-org/matrix-react-sdk#7418)). Fixes matrix-org/element-web-rageshakes#7331 element-hq/element-web#20246 and element-hq/element-web#20240.
* Fix HTML Export where the data-mx-theme is `Light` not `light` ([\#7415](matrix-org/matrix-react-sdk#7415)).
* Don't disable username/password fields whilst doing wk-lookup ([\#7438](matrix-org/matrix-react-sdk#7438)). Fixes element-hq/element-web#20121.
* Prevent keyboard propagation out of context menus ([\#7437](matrix-org/matrix-react-sdk#7437)). Fixes element-hq/element-web#20317.
* Fix nulls leaking into geo urls ([\#7433](matrix-org/matrix-react-sdk#7433)).
* Fix zIndex of peristent apps in miniMode ([\#7429](matrix-org/matrix-react-sdk#7429)).
* Space panel should watch spaces for space name changes ([\#7432](matrix-org/matrix-react-sdk#7432)).
* Fix list formatting alternating on edit ([\#7422](matrix-org/matrix-react-sdk#7422)). Fixes element-hq/element-web#20073. Contributed by @renancleyson-dev.
* Don't show `Testing small changes` without UIFeature.Feedback ([\#7427](matrix-org/matrix-react-sdk#7427)). Fixes element-hq/element-web#20298.
* Fix invisible toggle space panel button ([\#7426](matrix-org/matrix-react-sdk#7426)). Fixes element-hq/element-web#20279.
* Fix legacy breadcrumbs wrongly showing up ([\#7425](matrix-org/matrix-react-sdk#7425)).
* Space Panel use SettingsStore instead of SpaceStore as source of truth ([\#7404](matrix-org/matrix-react-sdk#7404)). Fixes element-hq/element-web#20250.
* Fix inline code block nowrap issue ([\#7406](matrix-org/matrix-react-sdk#7406)).
* Fix notification badge for All Rooms space ([\#7401](matrix-org/matrix-react-sdk#7401)). Fixes element-hq/element-web#20229.
* Show error if could not load space hierarchy ([\#7399](matrix-org/matrix-react-sdk#7399)). Fixes element-hq/element-web#20221.
* Increase gap between ELS and the subsequent event to prevent overlap ([\#7391](matrix-org/matrix-react-sdk#7391)). Fixes element-hq/element-web#18319.
* Fix list of members in space preview ([\#7356](matrix-org/matrix-react-sdk#7356)). Fixes element-hq/element-web#19781.
* Fix sizing of e2e shield in bubble layout ([\#7394](matrix-org/matrix-react-sdk#7394)). Fixes element-hq/element-web#19090.
* Fix bubble radius wrong when followed by a state event from same user ([\#7393](matrix-org/matrix-react-sdk#7393)). Fixes element-hq/element-web#18982.
* Fix alignment between ELS and Events in bubble layout ([\#7392](matrix-org/matrix-react-sdk#7392)). Fixes element-hq/element-web#19652 and element-hq/element-web#19057.
* Don't include the accuracy parameter in location events if accuracy could not be determined. ([\#7375](matrix-org/matrix-react-sdk#7375)).
* Make compact layout only apply to Modern layout ([\#7382](matrix-org/matrix-react-sdk#7382)). Fixes element-hq/element-web#18412.
* Pin qrcode to fix e2e verification bug ([\#7378](matrix-org/matrix-react-sdk#7378)). Fixes element-hq/element-web#20188.
* Add internationalisation to progress strings in room export dialog ([\#7385](matrix-org/matrix-react-sdk#7385)). Fixes element-hq/element-web#20208.
* Prevent escape to cancel edit from also scrolling to bottom ([\#7380](matrix-org/matrix-react-sdk#7380)). Fixes element-hq/element-web#20182.
* Fix narrow mode composer buttons for polls labs ([\#7386](matrix-org/matrix-react-sdk#7386)). Fixes element-hq/element-web#20067.
* Fix useUserStatusMessage exploding on unknown user ([\#7365](matrix-org/matrix-react-sdk#7365)).
* Fix room join spinner in room list header ([\#7364](matrix-org/matrix-react-sdk#7364)). Fixes element-hq/element-web#20139.
* Fix room search sometimes not opening spotlight ([\#7363](matrix-org/matrix-react-sdk#7363)). Fixes matrix-org/element-web-rageshakes#7288.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Jitsi O-Occasional Affects or can be seen by some users regularly or most users rarely Privacy S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants