Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-inviting to a rejected invite isn't syncing #22106

Closed
hifi opened this issue May 7, 2022 · 2 comments · Fixed by matrix-org/matrix-js-sdk#2374
Closed

Re-inviting to a rejected invite isn't syncing #22106

hifi opened this issue May 7, 2022 · 2 comments · Fixed by matrix-org/matrix-js-sdk#2374
Assignees
@turt2live
Labels
A-Notifications A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@hifi
Copy link

hifi commented May 7, 2022

Steps to reproduce

  1. Have a (possibly private) room #R and user A who can invite to it
  2. A: invite B to #R
  3. B: reject invite to #R (from Element web)
  4. A: re-invite B to #R

Outcome

What did you expect?

New invite is shown in Element web that can be used to join.

Hydgrogen works correctly as an example.

What happened instead?

Nothing (visually).

If I /join the room id by hand or through a clickable link the room is joined but the room state is completely wrong until clear cache & refresh. This may be due to a rejected room being moved to "historical" rooms and the state not being refreshed when joining back.

Operating system

Linux

Browser information

Firefox 91.8.0esr

URL for webapp

https://develop.element.io

Application version

Element version: a94323f-react-c86040b77a48-js-da69ca215b9c Olm version: 3.2.8

Homeserver

Synapse 1.5x

Will you send logs?

Yes
@hifi hifi added the T-Defect label May 7, 2022
@kerryarchibald kerryarchibald added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Room-List A-Notifications labels May 9, 2022
@turt2live
Copy link
Member

This looks like an annoying bug in the room list:

!CWPHJgjUpaifgZrhMC:localhost is reportedly new but is already known - assuming TagChange instead

so it's not jumping from Archive -> Invited for some reason.

@turt2live turt2live self-assigned this May 16, 2022
@turt2live
Copy link
Member

looks like this is actually more sinister: the js-sdk isn't even emitting anything for the room. It's an easy fix, but testing it will be interesting.

@turt2live turt2live mentioned this issue May 17, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jun 7, 2022
@su-ex
Merge tag 'v18.1.0' into sc
ee15b18 
* Convert `getLocalAliases` to a stable API call ([\matrix-org#2402](matrix-org#2402)).
* Fix request, crypto, and bs58 imports ([\matrix-org#2414](matrix-org#2414)). Fixes matrix-org#2415.
* Update relations after every decryption attempt ([\matrix-org#2387](matrix-org#2387)). Fixes element-hq/element-web#22258. Contributed by @weeman1337.
* Fix degraded mode for the IDBStore and test it ([\matrix-org#2400](matrix-org#2400)). Fixes matrix-org/element-web-rageshakes#13170.
* Don't cancel SAS verifications if `ready` is received after `start` ([\matrix-org#2250](matrix-org#2250)).
* Prevent overlapping sync accumulator persists ([\matrix-org#2392](matrix-org#2392)). Fixes vector-im/element-web#21541.
* Fix behaviour of isRelation with relation m.replace for state events ([\matrix-org#2389](matrix-org#2389)). Fixes element-hq/element-web#22280.
* Fixes matrix-org#2384 ([\matrix-org#2385](matrix-org#2385)). Fixes undefined/matrix-js-sdk#2384. Contributed by @schmop.
* Ensure rooms are recalculated on re-invites ([\matrix-org#2374](matrix-org#2374)). Fixes element-hq/element-web#22106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Notifications A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure rooms are recalculated on re-invites matrix-org/matrix-js-sdk
3 participants
@hifi @turt2live @kerryarchibald