Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline does not display state events with m.replace relation unless "hidden events" are enabled #22280

Closed
richvdh opened this issue May 19, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2389
Closed

Timeline does not display state events with m.replace relation unless "hidden events" are enabled #22280

richvdh opened this issue May 19, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2389
Assignees
@t3chguy
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist Security T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented May 19, 2022 •
edited
Loading

Steps to reproduce

  1. disable "Show hidden events in timeline" via /devtools
  2. send an m.room.topic state event with this content:
{
  "topic":"spam spam", 
  "m.relates_to": {"rel_type":"m.replace","event_id":"<previous topic event>"}
}

Outcome

What did you expect?

This event changes the topic of the room (irrespective of the spurious m.replace relation), so should be shown in the timeline.

image

What happened instead?

Event is not shown (until hidden events are enabled):

image

Operating system

ubuntu 20.04

Browser information

Firefox

URL for webapp

develop.element.io

Application version

Element version: d36dcd2-react-82169ab92354-js-2dccefb33a9d Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

No
@richvdh richvdh mentioned this issue May 19, 2022
Closed
@andybalaam andybalaam added S-Minor Impairs non-critical functionality or suitable workarounds exist Security O-Uncommon Most users are unlikely to come across this or unexpected workflow labels May 19, 2022
@t3chguy t3chguy self-assigned this May 20, 2022
@t3chguy t3chguy mentioned this issue May 20, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jun 7, 2022
@su-ex
Merge tag 'v18.1.0' into sc
ee15b18 
* Convert `getLocalAliases` to a stable API call ([\matrix-org#2402](matrix-org#2402)).
* Fix request, crypto, and bs58 imports ([\matrix-org#2414](matrix-org#2414)). Fixes matrix-org#2415.
* Update relations after every decryption attempt ([\matrix-org#2387](matrix-org#2387)). Fixes element-hq/element-web#22258. Contributed by @weeman1337.
* Fix degraded mode for the IDBStore and test it ([\matrix-org#2400](matrix-org#2400)). Fixes matrix-org/element-web-rageshakes#13170.
* Don't cancel SAS verifications if `ready` is received after `start` ([\matrix-org#2250](matrix-org#2250)).
* Prevent overlapping sync accumulator persists ([\matrix-org#2392](matrix-org#2392)). Fixes vector-im/element-web#21541.
* Fix behaviour of isRelation with relation m.replace for state events ([\matrix-org#2389](matrix-org#2389)). Fixes element-hq/element-web#22280.
* Fixes matrix-org#2384 ([\matrix-org#2385](matrix-org#2385)). Fixes undefined/matrix-js-sdk#2384. Contributed by @schmop.
* Ensure rooms are recalculated on re-invites ([\matrix-org#2374](matrix-org#2374)). Fixes element-hq/element-web#22106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist Security T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix behaviour of isRelation with relation m.replace for state events matrix-org/matrix-js-sdk
3 participants
@andybalaam @richvdh @t3chguy