Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show who reacted to what in tooltip on hover #9722

Closed
nadonomy opened this issue May 14, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#2998
Closed

Show who reacted to what in tooltip on hover #9722

nadonomy opened this issue May 14, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#2998
Assignees
@jryans
Labels
A-Aggregations A-Reactions T-Enhancement

Comments

@nadonomy
Copy link
Contributor

nadonomy commented May 14, 2019 •
edited
Loading

(Internal) Zeplin link: https://zpl.io/a3e7okQ

Screenshot 2019-05-14 at 21 06 33

  • Sorted in ascending time order of reaction
  • Clip at 6 names and show "& N more"

Tooltip colours:

  • Background: Inherit from left-left-panel per theme
  • 'Name': White in light, message body (#EDF3FF) in dark
  • 'Reacted with': 70% opacity of the above
@turt2live
Copy link
Member

How many names to clip at, and if we do, whether we display '& x more'

ftr I like github's approach of showing 10 and the "& more":
image

@nadonomy nadonomy mentioned this issue May 15, 2019
Closed
@Half-Shot

This comment has been minimized.

Sign in to view
@jryans

This comment has been minimized.

Sign in to view
@Half-Shot

This comment has been minimized.

Sign in to view
@jryans jryans added phase:1 and removed phase:3 labels May 16, 2019
@jryans jryans self-assigned this May 16, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue May 17, 2019
@jryans
Add a basic tooltip showing who reacted
3da1f73 
This adds a first attempt at tooltip showing who reacted to a message. It
doesn't limit senders or position the tooltip nicely, but the info is there at
least.

Part of element-hq/element-web#9722
@jryans jryans mentioned this issue May 17, 2019
Merged
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue May 20, 2019
@jryans
Limit reaction sender tooltip to 6 people
1bc9bad 
This limits the number of senders shown in the reaction sender tooltip shown
when hovering a reaction to 6 people followed by "and N others" for the rest.

Fixes element-hq/element-web#9722
@jryans jryans mentioned this issue May 20, 2019
Merged
@manuroe manuroe mentioned this issue Jul 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Aggregations A-Reactions T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit reaction sender tooltip to 6 people matrix-org/matrix-react-sdk
5 participants
@jryans @turt2live @lampholder @Half-Shot @nadonomy