This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add a basic tooltip showing who reacted #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By first substituting variables and then tags after, the translation handling can now support strings with variables inside tags, such as: "people <span>reacted with %(foo)s</span>"
This adds a first attempt at tooltip showing who reacted to a message. It doesn't limit senders or position the tooltip nicely, but the info is there at least. Part of element-hq/element-web#9722
We want to use the same styling with edited tooltip as well, so this extracts the shared bits.
bwindels
approved these changes
May 17, 2019
bwindels
reviewed
May 17, 2019
|
Just passing to say that I'm a simple user testing Riot with labs features actived on https://riot.im/develop/ and I LOVE the new changes you're all working on. Believe me people will go crazy for them when it's out. Keep up the good work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tweaks the edited tooltip to match:
This does not match the designed tooltip, but it's a step along the way.
Part of element-hq/element-web#9722