Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places: New design for folder icons #1311

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

newhoa
Copy link
Collaborator

@newhoa newhoa commented Sep 17, 2024

Combines the newer design of the system-file-manager app icon with the color palette of the current folder icons. Also adjusts the aspect ratio to make it slightly wider, so it is not quite as square as system-file-manager but not quite as wide as the current folder icons.

Closes #1305


This is what has been done as of the initial PR:

  • Basic folder at all sizes
  • XDG User Directories at 48px and 64px
  • folder-open (drag-accept) at 48px

My initial thoughts/questions:

1) I am thinking the 16px folder should be slightly less rounded? (went ahead and adjusted this)
2) I just added folder-open at 48px, feedback for that one would be appreciated before I start on any other sizes.
4) Is the aspect ratio of folder okay? (personally, I am liking it a lot the more I use them so I hope that can stick).

Any feedback would be appreciated!

Thanks!

Use the new rounded folder style from the
`system-file-manager` app icon for folders.
Add base `folder` icon at missing sizes

Clean up borders of existing folders.
Fix inconsistent aspect ratio between sizes.
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are so good! I especially like how much more open the folder-open is here. It looks like it has a lot more dimension to it. Great job

Proportions of everything looks good, and I noticed these fit the baseline better compared to other icons which is really great.

Honestly these are really lovely and they do look way more modern which is great. I just had a few little nitpicks, so I opened a branch I figured that would be easier than trying to type it out: newhoa#1

@newhoa newhoa marked this pull request as ready for review October 27, 2024 12:23
@newhoa
Copy link
Collaborator Author

newhoa commented Oct 27, 2024

Okay, I think these are ready for review!

Went ahead and adjusted the shadows, gradients, and highlights for all sizes as suggested by @danirabbit here. Added folder-open remaining sizes, did the XDG emblemed folders, etc.

Let me know if anything needs adjusting!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICON - FOLDER - Standardize folder icons
2 participants