Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64: Adjust highlight and shadow #1

Conversation

danirabbit
Copy link

@danirabbit danirabbit commented Sep 20, 2024

These look really good! My only real comments here are:

  • I think the brighter 50% opacity highlight on the outside of the folder works better here than only 30% highlight
  • I added back in the shadow here that was missing compared to system-file-manager. I think it just gives it a bit more dimension
  • I slightly adjusted the gradient stops on the outside of the folder, I think there weren't quite to the edges
  • I also used the same shadow from system-file-manager and just adjusted opacity here so it wasn't so harsh with the lighter folder color

@newhoa
Copy link
Owner

newhoa commented Oct 16, 2024

Sorry, I got a little behind on working on these. I'll try to do some work on them over the next week or so.

Thanks for the input and work on these adjustments! I like the improved highlight and more subtle shadow. I like the inner shadowing put back in.

2 things I sort of miss after these changes. This may just be my needing to adjust to them.

One, the inner shadowing makes the top border a little darker and strong. While checking that out, it made me notice that the border isn't using the elementary palette (maybe some color midpoint between palette colors, I'm not sure). So at some point maybe I'll both try to use a palette color and maybe do a slight border gradient to slightly soften the top border.

Two, adjusting the gradient stops removes a little bit of its curviness/depth. It looks a little bit flatter. When adapting system-file-manager, I kept the Latte gradient stops in the same spots as they were in folder. Since the previous folder was a bit shorter, the stops were also. But this also meant it kept the same look of gradient depth. Spreading the gradient removes a little bit of that and a little bit of that curve/glow toward the top.

These might just be things I'm noticing because I've been living with the v1 ones for a while. I'll merge these new adjustments, make the same changes for the other sizes, and live with them for a while! I guess if down the road I still end up missing those parts and come up with any adjustments that are worth sharing I'll propose them later on.

Thanks again for the help!


Gonna put before (v1) and after (v2) this point changes here just for future reference for myself.

v1:
64_v1

v2:
64_v2

@newhoa newhoa merged commit e493103 into newhoa:places-rounded-folder Oct 26, 2024
3 checks passed
@newhoa newhoa deleted the danirabbit/places-rounded-folder branch October 26, 2024 02:05
@teamcons
Copy link

teamcons commented Oct 29, 2024

These are lovely ! The roundness make them very friendly-looking, and i am glad you kept the general latte color. It pops the right amount.
I like large/wide, because of the contrast with app icons, but i can get used to these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants