chore(deps): upgrade all dependencies and ember-cli #135

buschtoens · 2018-10-23T13:40:31Z

I'm having trouble getting ember-fetch to run with the latest ember-cli. Prior to this PR broccoli-rollup would not find the env preset.

Now I'm getting a different error:

  - broccoliBuilderErrorStack: TypeError: Cannot read property 'bindings' of null
    at error (/Users/janbuschtoens/clark/application/node_modules/broccoli-rollup/node_modules/rollup/dist/rollup.js:224:15)
    at Object.error (/Users/janbuschtoens/clark/application/node_modules/broccoli-rollup/node_modules/rollup/dist/rollup.js:17174:21)
    at /Users/janbuschtoens/clark/application/node_modules/broccoli-rollup/node_modules/rollup/dist/rollup.js:17183:29
    at process._tickCallback (internal/process/next_tick.js:68:7)
  - codeFrame: Cannot read property 'bindings' of null
  - errorMessage: Cannot read property 'bindings' of null
        at Rollup
-~- created here: -~-
    at new Plugin (/Users/janbuschtoens/clark/application/node_modules/broccoli-plugin/index.js:7:31)
    at new Rollup (/Users/janbuschtoens/clark/application/node_modules/broccoli-rollup/dist/index.js:39:9)
    at treeForBrowserFetch (/Users/janbuschtoens/clark/application/client-packages/addons/ember-clark-api/node_modules/ember-fetch/index.js:136:31)
    at Class.treeForVendor (/Users/janbuschtoens/clark/application/client-packages/addons/ember-clark-api/node_modules/ember-fetch/index.js:112:23)
    at Class._treeFor (/Users/janbuschtoens/clark/application/client/node_modules/ember-cli/lib/models/addon.js:616:33)
    at Class.treeFor (/Users/janbuschtoens/clark/application/client/node_modules/ember-cli/lib/models/addon.js:576:21)
    at addons.reduce (/Users/janbuschtoens/clark/application/client/node_modules/ember-cli/lib/models/addon.js:449:26)
    at Array.reduce (<anonymous>)
    at Class.eachAddonInvoke (/Users/janbuschtoens/clark/application/client/node_modules/ember-cli/lib/models/addon.js:446:24)
    at Class.treeFor (/Users/janbuschtoens/clark/application/client/node_modules/ember-cli/lib/models/addon.js:575:22)
-~- (end) -~-
  - errorType: Build Error
  - location:
    - column: [undefined]
    - file: [undefined]
    - line: [undefined]
    - treeDir: [undefined]
  - message: Cannot read property 'bindings' of null
        at Rollup
-~- created here: -~-
    at new Plugin (/Users/janbuschtoens/clark/application/node_modules/broccoli-plugin/index.js:7:31)
    at new Rollup (/Users/janbuschtoens/clark/application/node_modules/broccoli-rollup/dist/index.js:39:9)
    at treeForBrowserFetch (/Users/janbuschtoens/clark/application/client-packages/addons/ember-clark-api/node_modules/ember-fetch/index.js:136:31)
    at Class.treeForVendor (/Users/janbuschtoens/clark/application/client-packages/addons/ember-clark-api/node_modules/ember-fetch/index.js:112:23)
    at Class._treeFor (/Users/janbuschtoens/clark/application/client/node_modules/ember-cli/lib/models/addon.js:616:33)
    at Class.treeFor (/Users/janbuschtoens/clark/application/client/node_modules/ember-cli/lib/models/addon.js:576:21)
    at addons.reduce (/Users/janbuschtoens/clark/application/client/node_modules/ember-cli/lib/models/addon.js:449:26)
    at Array.reduce (<anonymous>)
    at Class.eachAddonInvoke (/Users/janbuschtoens/clark/application/client/node_modules/ember-cli/lib/models/addon.js:446:24)
    at Class.treeFor (/Users/janbuschtoens/clark/application/client/node_modules/ember-cli/lib/models/addon.js:575:22)
-~- (end) -~-
  - name: BuildError
  - nodeAnnotation: [undefined]
  - nodeName: Rollup
  - originalErrorMessage: Cannot read property 'bindings' of null
  - stack: TypeError: Cannot read property 'bindings' of null
    at error (/Users/janbuschtoens/clark/application/node_modules/broccoli-rollup/node_modules/rollup/dist/rollup.js:224:15)
    at Object.error (/Users/janbuschtoens/clark/application/node_modules/broccoli-rollup/node_modules/rollup/dist/rollup.js:17174:21)
    at /Users/janbuschtoens/clark/application/node_modules/broccoli-rollup/node_modules/rollup/dist/rollup.js:17183:29
    at process._tickCallback (internal/process/next_tick.js:68:7)

Anyhow, this PR might be beneficial either way.

buschtoens · 2018-10-23T13:59:03Z

Sweet. Now this build also fails. So it's not just me. Haha. 😄

buschtoens · 2018-10-23T15:21:51Z

I've tested my branch with a yarn resolution in our application using the latest ember-cli and it works perfectly now! 🚀

buschtoens · 2018-10-23T18:08:49Z

Resolved merge conflicts by rebasing onto latest master.

buschtoens · 2018-11-01T17:20:45Z

@nlfurniss @xg-wang Any chance that we can merge this? Happy to rebase again.

xg-wang

Yeah would be great to get this in.
This will be a breaking change as it drops node 6 and ember-cli < 2.12

We can get this in after a patch version #140 then do a major bump.

index.js

buschtoens · 2018-11-03T17:31:39Z

I've rebased onto the latest master. 😊

xg-wang · 2018-11-10T03:19:34Z

I think we can make it a new major after #143, which will be a new minor.

Turbo87 · 2018-11-14T15:45:42Z

package.json

    "loader.js": "^4.2.3",
    "mocha": "^5.2.0"
  },
  "engines": {
-    "node": "6.* || 8.* || >= 10"
+    "node": "8.* || >= 10"


@buschtoens why did you drop Node 6 support?

To quote Jeff Sessions: "I do not recall."

I think it was because one of the dependencies I've updated dropped Node 6 support. I can checkout the PR again later and see, whether this is actually the case and whether we can avoid that one dep to get this out the door.

I've rebased and reverted that commit. Let's see, if the Travis goes green. :)

https://travis-ci.org/ember-cli/ember-fetch/builds/455055560

This reverts commit 077f3fd.

xg-wang · 2018-11-14T23:35:44Z

test/prefer-native-test.js


    it(`${
      preferNative ? 'Prefers' : "Doesn't prefer"
-    } native fetch as specified`, async function() {
-      await output.build();
+    } native fetch as specified`, co.wrap(function*() {


Why use co instead of async?

Because co is supported by Node 6 and async is not

buschtoens · 2019-01-07T09:54:06Z

Since #162 & #163 have been merged, I think we can close this.

buschtoens force-pushed the upgrade branch from 4ddb50d to 5a675a9 Compare October 23, 2018 13:56

buschtoens force-pushed the upgrade branch from 7c661a6 to 424458a Compare October 23, 2018 18:07

xg-wang requested changes Nov 1, 2018

View reviewed changes

index.js Show resolved Hide resolved

buschtoens force-pushed the upgrade branch from 424458a to 9fed24f Compare November 3, 2018 17:31

Turbo87 added the breaking label Nov 14, 2018

Turbo87 reviewed Nov 14, 2018

View reviewed changes

This was referenced Nov 14, 2018

Ember-Cli 3.5 + Ember-Fetch 6.1.0 + Monorepo Build Fails #156

Closed

Ember-Cli 3.5 + Ember-Fetch 6.1.0 + Monorepo Build Fails ember-cli/ember-cli#8192

Closed

buschtoens added 8 commits November 14, 2018 16:52

chore(deps): upgrade dependencies

bb8658a

chore(deps): upgrade ember-cli

1b103a7

fix(ci): remove lint:hbs

80ceb4b

fix(ci): set correct node version

077f3fd

fix(build): use @babel/preset-env

22437a9

fix(build): use @babel/core

008cbd1

chore(deps): update yarn.lock

9d8feeb

Revert "fix(ci): set correct node version"

2a9d754

This reverts commit 077f3fd.

buschtoens force-pushed the upgrade branch from 9fed24f to 2a9d754 Compare November 14, 2018 15:57

buschtoens added 2 commits November 14, 2018 17:14

refactor(test/prefer-native): use co instead of async fn

01b6daf

test(prefer-native): increase timeout

6dc9d20

xg-wang reviewed Nov 14, 2018

View reviewed changes

buschtoens closed this Jan 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): upgrade all dependencies and ember-cli #135

chore(deps): upgrade all dependencies and ember-cli #135

buschtoens commented Oct 23, 2018 •

edited

Loading

buschtoens commented Oct 23, 2018

buschtoens commented Oct 23, 2018

buschtoens commented Oct 23, 2018

buschtoens commented Nov 1, 2018

xg-wang left a comment

buschtoens commented Nov 3, 2018

xg-wang commented Nov 10, 2018

Turbo87 Nov 14, 2018

buschtoens Nov 14, 2018

buschtoens Nov 14, 2018 •

edited

Loading

xg-wang Nov 14, 2018

Turbo87 Nov 15, 2018

buschtoens commented Jan 7, 2019

chore(deps): upgrade all dependencies and ember-cli #135

chore(deps): upgrade all dependencies and ember-cli #135

Conversation

buschtoens commented Oct 23, 2018 • edited Loading

buschtoens commented Oct 23, 2018

buschtoens commented Oct 23, 2018

buschtoens commented Oct 23, 2018

buschtoens commented Nov 1, 2018

xg-wang left a comment

Choose a reason for hiding this comment

buschtoens commented Nov 3, 2018

xg-wang commented Nov 10, 2018

Turbo87 Nov 14, 2018

Choose a reason for hiding this comment

buschtoens Nov 14, 2018

Choose a reason for hiding this comment

buschtoens Nov 14, 2018 • edited Loading

Choose a reason for hiding this comment

xg-wang Nov 14, 2018

Choose a reason for hiding this comment

Turbo87 Nov 15, 2018

Choose a reason for hiding this comment

buschtoens commented Jan 7, 2019

buschtoens commented Oct 23, 2018 •

edited

Loading

buschtoens Nov 14, 2018 •

edited

Loading