Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test/prefer-native): use co instead of async fn & run in CI #162

Merged
merged 2 commits into from
Nov 15, 2018
Merged

refactor(test/prefer-native): use co instead of async fn & run in CI #162

merged 2 commits into from
Nov 15, 2018

Conversation

buschtoens
Copy link
Contributor

@buschtoens buschtoens commented Nov 15, 2018 •
edited
Loading

Make Node tests runnable on Node 6.

Note: does not yet actually run these tests in CI.

@buschtoens buschtoens changed the title refactor(test/prefer-native): use co instead of async fn refactor(test/prefer-native): use co instead of async fn & run in CI Nov 15, 2018
Turbo87
Turbo87 approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muchas gracias!

@Turbo87 Turbo87 merged commit f4042ea into ember-cli:master Nov 15, 2018
@buschtoens buschtoens deleted the async-to-co branch November 15, 2018 15:23
@buschtoens buschtoens mentioned this pull request Jan 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buschtoens @Turbo87