find templates with custom babel parser

[patricklx]

i noticed that the current template parsing has issues.

I created a custom parser for babel which can parse the template tags.
https://babeljs.io/docs/babel-parser#will-the-babel-parser-support-a-plugin-system

I also added a conditional prefix to fix #171

[patricklx]

Will try with htmlparser2. No need for full spec (parse5) compliance here. Better fast and forgiving :)

[patricklx]

this is ready now

[patricklx]

@dfreeman @ef4 @chriskrycho what do you think?

[dfreeman]

I'm not an active maintainer here or on Embroider, but my guess is that https://github.com/embroider-build/content-tag is a more complete solution to the issues you're aiming to tackle here.

[ef4]

Yes, that is correct and we hope that content-tag is the much more robust solution. It's rust compiled to wasm, based on SWC so it has the benefit of a full javascript parser.

The intention is to PR changes to ember-template-imports that would use content-tag to replace the preprocessor stage, and the babel stage here will also not be needed at all because babel-plugin-ember-template-compilation has already shipped the corresponding feature that goes with content-tag.

[patricklx]

What about other packages that depend on this to find the template parts? Like the eslint ember plugin. template lint etc.
Though i would be happy to make a pr for content-tag

[ef4]

Yes we want to standardize all those things on content-tag too. We can output whatever info from it is most convenient for those tools.

It's actually problematic right now that the preprocessor here lives in a classic ember addon. It's bad that things like template lint need to depend on this full addon, because the addon does more than just provide the preprocessor library.

[patricklx]

So, it is already in a state that can be used for this?

[patricklx]

content-tag does not look like its ready #182

[patricklx]

also extracted this into: https://github.com/patricklx/ember-template-preprocessor

[ef4]

Thanks for starting this work, I was able to extract a reproduction of the bug you found. embroider-build/content-tag#16

[NullVoxPopuli]

gonna close this as

• bulk of the work was extracted to another project
• we have content-tag

thanks again for your hard work @patricklx, it's much appreciated!