Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use content-tag #182

Closed
wants to merge 2 commits into from
Closed

Conversation

patricklx
Copy link
Contributor

example for using content-tag,
but its not passing the tests.
e.g.

let Foo = class Foo extends Component {
    greeting = 'Hello';
    <template>{{this.greeting}}, {{@name}}!</template>
};

does not get translated

@ef4
Copy link
Collaborator

ef4 commented Jul 22, 2023

The bug you found is fixed in content-tag 1.0.1.

The remaining steps needed to make this work are:

  • ensuring that users have babel-plugin-ember-template-compilation >= 2.1.0 (because that implements Ember RFC 931, which is what content-tag is outputting)
  • ensure that users who are using @babel/plugin-proposal-decorators (which is all ember users) also have @babel/plugin-transform-class-static-block (because the decorators transform forces you to also transpile other class features like static blocks, and content-tag uses static blocks)

I think the best way to release this is to update ember-cli-babel to setup both of those plugins, and then when we can release a new version of ember-template-imports that says what minimum ember-cli-babel version it needs.

@patricklx
Copy link
Contributor Author

@ef4 sounds good. What about the moduleName issue?

@patricklx patricklx marked this pull request as ready for review July 27, 2023 21:42
@NullVoxPopuli
Copy link
Collaborator

Superceded by #187

Thanks for your efforts! They've been immensely helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants