Downgraded fs-extra version to 6.x to fix a fs.copy related issue. #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #912 +/- ##
=======================================
Coverage 94.36% 94.36%
=======================================
Files 17 17
Lines 550 550
=======================================
Hits 519 519
Misses 31 31 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 3 commits
February 8, 2023 10:11
fs-extra brought in a breaking change here: jprichardson/node-fs-extra#582 where it breaks ember-try when copying node_modules/ and there's a symlink in it. The bug would either prevent ember-try from running or cleaning up after try-each. @co-authored-by hjdivad
hjdivad
force-pushed
the
laryu/fix-broken-cleanup
branch
from
2d14d9d
to
e593488
Compare
|
@larry-x-yu i rebased your branch after merging #913 |
|
Merging to fix the regression. Longer-term it would be nice to upgrade fs-extra (being sensitive to the breaking change) or otherwise fix up the copying behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs-extra brought in a breaking change here:
jprichardson/node-fs-extra#582
where it breaks ember-try when copying node_modules/ and there's a symlink in it. The bug would either prevent ember-try from running or cleaning up after try-each.
Testing done:
yarn testpassed locally.@co-authored-by hjdivad