Migrate to monorepo structure (to easily add test apps) #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2020
kiwiupover
force-pushed
the
monorepo
branch
2 times, most recently
from
c2078ec
to
67fdfc7
Compare
rwjblue
reviewed
Jul 24, 2020
There was a problem hiding this comment.
Looks good overall, I think we need to do a couple things:
- Rebase on top of Remove travis in-favor of GitHub actions #773 (once it lands)
- Ensure the top level README is a duplicate of hte package's README (eventually we can add a GH Actions job to validate, but just copying for now is fine)
- Create a
CONTRIBUTING.md(starting with the default one would be good) that mentions how to link / use the nested workspace for linking purposes - Copy the LICENSE file into the project root
.github/workflows/ci.yml
Outdated
| @@ -0,0 +1,66 @@ | |||
| name: CI | |||
There was a problem hiding this comment.
Should drop away when we rebase
.travis.yml
Outdated
| @@ -29,6 +29,7 @@ cache: | |||
| before_install: | |||
| - npm config set spin false | |||
| - npm install -g npm@4 | |||
| - cd packages/ember-cli-fastboot | |||
There was a problem hiding this comment.
I think this change will have to be made over in the GH actions setup.
appveyor.yml
Outdated
| @@ -17,6 +17,7 @@ branches: | |||
| install: | |||
| - ps: Install-Product node $env:nodejs_version | |||
| - npm config set spin false | |||
| - cd packages/ember-cli-fastboot | |||
There was a problem hiding this comment.
I think this file will be deleted
rwjblue
reviewed
Jul 24, 2020
Comment on lines
+94
to
+106
| "release-it": { | ||
| "plugins": { | ||
| "release-it-lerna-changelog": { | ||
| "infile": "CHANGELOG.md" | ||
| } | ||
| }, | ||
| "git": { | ||
| "tagName": "v${version}" | ||
| }, | ||
| "github": { | ||
| "release": true | ||
| } | ||
| }, |
There was a problem hiding this comment.
We'll need to tweak this too, I'll do that in a follow up.
| @@ -41,7 +41,7 @@ jobs: | |||
| - name: Yarn Install | |||
| run: yarn install --ignore-engines | |||
| - name: Run Mocha Tests | |||
| run: yarn test:mocha | |||
| run: yarn workspace ember-cli-fastboot test:mocha | |||
There was a problem hiding this comment.
These commands are failing CI, not exactly sure why. Can you run it locally without error?
There was a problem hiding this comment.
I closed the PR and re opened the PR again and it is now working.
@rwjblue ^^
rwjblue
approved these changes
Jul 25, 2020
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ember-cli-fastboot addon to packages/ember-cli-fastboot
This PR is the base for moving tests to a monorepo structure following the discussion here.
#765