Adding monorepo tests apps #768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move module-whitelist to test-packages folder Adding first test remove test-packages for test backward compatibility adding package-json tests adding github actions Update ci.yml Rework version value
|
Closing this PR in favor of smaller ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problems
The current test setup needs to run against npm 4 because we are swapping node modules at build time. Both
npm5+ andyarnexpect node modules to be referenced from a repository or from disk somewhere. Prenpm5+ node modules in present in thenode_moduleswould be included whennpm installis run.ember-cli-addon-tests builds uses [email protected] ember-cli-fastboot needs to tests against a wide rage of dependancies
We need to add tests for an embroider application.
The case for a monorepo
We add
test-packageapplications so we can tests again each of the scenariosember-cli-fastbootsupports. We would add anembroiderapplication and run tests against that app. A number of addons have has success with this approachember-auto-importbeing one.Proposed test structure
I propose that we have singular focused tests and a
test-packageeach of those focuses.An alternative could be we have a single custom app with all the customization tested in that application. I don't like this idea because it will be hard to fellow contributors to follow the customizations .
Use github actions
This is a no brainer. Test are much faster.
Here is the same PR on my repo running github actions. kiwiupover#8
I don't know why github actions don't run for a PR from a forked repo.
This PR branches from the monoropo PR #767 and should be merged following the merge of that PR.
I broke down package-json-test.js into separate tests with corresponding test-package applications
Adding test-packages for
@rwjblue @kratiahuja, @SparshithNR and @mansona I would love to hear your thoughts about this approach.