Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation guide Ember.Component.reopen #948

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

Glarregle
Copy link
Contributor

@Glarregle Glarregle commented Sep 6, 2021

Progress #893

@ijlee2
Copy link
Member

ijlee2 commented Sep 6, 2021

@Glarregle When you click on Details, you will be able to preview the website. Thank you for helping with documentation!

netlify_deploy_preview

@locks Could you help with reviewing the pull request?

@Glarregle
Copy link
Contributor Author

Glarregle commented Sep 6, 2021

@Glarregle When you click on Details, you will be able to preview the website. Thank you for helping with documentation!

@ijlee2 I'm aware, thank you! Source code update PR should follow

Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the last learning team meeting, we want to merge deprecation entries ASAP so that we have links to add to the source code. If there are any changes requested by reviewers, please open followup PRs.

Thank you @Glarregle for your work!

@jenweber jenweber merged commit b1ce3b7 into ember-learn:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants