Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC beta] Deprecation link for Ember.Component.reopen #19744

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

Glarregle
Copy link
Contributor

Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation guide has been merged, so this can move forward.

@Glarregle please mark your commit with [DOC beta] at the beginning of the commit message. This will help us make sure it gets in for the next release.

@jenweber jenweber changed the title Deprecation link for Ember.Component.reopen [DOC beta] Deprecation link for Ember.Component.reopen Sep 8, 2021
@Glarregle
Copy link
Contributor Author

Thanks @jenweber! Ready!

@locks locks enabled auto-merge October 1, 2021 13:30
@locks locks merged commit 831a52d into emberjs:master Oct 1, 2021
@mixonic
Copy link
Member

mixonic commented Oct 29, 2021

This needs to be rolled back. This deprecation was targeting 4.0, and we want to remove the functionality in 4.0. Followup from @chancancode is:

  • PR to move the deprecation guide to 3.x (also the link-to.disabled-when ones)
  • PR to change "until" back to 4.0 on master and beta, as well as updating the URL to 3.x
  • PR to backport adding the URL (and since) to 3.28

@jenweber
Copy link
Contributor

jenweber commented Nov 4, 2021

@mixonic PR to fix the versions #19823

Sorry for the confusion @Glarregle, we gave you the wrong instructions about version numbers. Thanks again for your help with fixing missing info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants