-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): handle module unification addons #277
Conversation
This upgrades ember-fetch to `^6.2.0`. The primary reason for upgrading are the fixes for: - Usage of ember-fetch in monorepos: ember-cli/ember-fetch#165 https://github.com/ember-cli/ember-fetch/releases/tag/v6.1.1 - Enabling Fastboot relative URLs: ember-cli/ember-fetch#143 https://github.com/ember-cli/ember-fetch/releases/tag/v6.2.0
962c44a
to
1b301e0
Compare
So this is working now for classic and MU. However, the story for how to test an addon with classic and MU dummy apps is still shaking out. I guess until then, we can't really write tests for MU. It would be sweet however, if this PR could be merged nonetheless, as the changes are rather minimal and don't interfere with the classic build pipeline, but would allow early MU adopters to keep experimenting with the mainline release of |
There is one minor issue I noticed: |
The The |
I just noticed that it's fixed now. I guess by ember-cli/ember-resolver#276, but I am not 💯 sure, but also don't wanna waste time finding the exact thing that fixed it. 😂
I've relocated the template in d21fa46, so that it may be imported by the consuming dummy app: // tests/dummy/src/ui/routes/docs/api/item/template.js
export { default } from 'ember-cli-addon-docs/templates/docs/api/item'; By doing it like this, even the nested components |
Maybe we can do some trickery with |
kind of want to wait until MU is finalized to support this? what does everyone think? Can always come back to it if/when that stuff ever shakes out |
I've heard from those on Ember core that MU is going through a rethink and will likely differ from the original vision. With that in mind, I am going to close this for now, and we can revisit when things flesh out more. |
I wanted to play around with ember-cli-addon-docs in a Module Unification addon, but hit some problems. This in combination with ember-cli/ember-cli#8197 fixes all problems for me.
The
ember-fetch
upgrade is required for monorepo addons. I'll rebase this PR, when #284 is merged.This PR here is also lacking tests for MU.