Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep guides content for Ember 4 - Do not merge until Ember 4 release WIP #1730

Merged
merged 5 commits into from
Dec 20, 2021
Merged

Prep guides content for Ember 4 - Do not merge until Ember 4 release WIP #1730

merged 5 commits into from
Dec 20, 2021

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Sep 2, 2021 •
edited
Loading

Closes #1713
Closes #1712

  • Make some stuff sound more past tense
  • Remove optional features info, because they aren't optional anymore in v4
  • Remove references to needing to use this.something in component templates, since doing otherwise isn't supported in Ember 4

@jenweber jenweber changed the title Prep upgrade guide for Ember 4 Prep upgrade guide for Ember 4 - Do not merge until Ember 4 release WIP Sep 2, 2021
@jenweber
Remove all optional features specifics
c5e43c2 
These were optional in 3.x. They are now
defaults for Ember 4.
@jenweber jenweber changed the title Prep upgrade guide for Ember 4 - Do not merge until Ember 4 release WIP Prep guide content for Ember 4 - Do not merge until Ember 4 release WIP Sep 2, 2021
@jenweber jenweber changed the title Prep guide content for Ember 4 - Do not merge until Ember 4 release WIP Prep guides content for Ember 4 - Do not merge until Ember 4 release WIP Sep 2, 2021
@jenweber
Copy link
Contributor Author

jenweber commented Sep 2, 2021 •
edited
Loading

Things I personally checked:

@jenweber jenweber mentioned this pull request Sep 2, 2021
Closed
19 tasks
@jenweber jenweber requested a review from a team December 16, 2021 16:56
jaredgalanis
jaredgalanis approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@jenweber jenweber merged commit 96191d6 into master Dec 20, 2021
@jenweber jenweber deleted the ember-4 branch December 20, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredgalanis jaredgalanis jaredgalanis approved these changes

@rwjblue rwjblue Awaiting requested review from rwjblue

@chancancode chancancode Awaiting requested review from chancancode

@locks locks Awaiting requested review from locks

@mixonic mixonic Awaiting requested review from mixonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ember 4: update the Upgrade Guide Ember 4: Update optional features documentation
2 participants
@jenweber @jaredgalanis