Reword some "Classic" references for Ember 4 #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenweber
force-pushed
the
ember-4-classic-references
branch
from
260d165
to
d806d95
Compare
19 tasks
ijlee2
reviewed
Sep 2, 2021
jenweber
force-pushed
the
ember-4-classic-references
branch
from
d806d95
to
f7a18a7
Compare
|
Sorry, thought I already reverted that. The PR for the tutorial is here: ember-learn/super-rentals-tutorial#194 Thanks for the review! |
ijlee2
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 lingering places outside the upgrade guides where we talk about classic components/classes.
For new developer experience, I recommend that we keep them around, but with some rewording. They are all over stack overflow.