Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link-to, input, and textarea to angle bracket invocation #837

Merged
merged 16 commits into from
Jul 2, 2019
Merged

Update link-to, input, and textarea to angle bracket invocation #837

merged 16 commits into from
Jul 2, 2019

Conversation

locks
Copy link
Contributor

@locks locks commented Jun 3, 2019 •
edited
Loading

  • Normalize "helper" and "component" referrences to component.
  • Review prose in "link-to component" guide for new API.
  • Update tutorial in a follow up PR to sync with codebase.

@locks locks changed the title Merge pull request #833 from ember-learn/dependabot/npm_and_yarn/ember-cli-fastboot-2.1.0 Update link-to, input, and textarea to angle bracket invocation Jun 3, 2019
@locks locks requested a review from a team June 3, 2019 15:56
rwjblue
rwjblue previously requested changes Jun 3, 2019
View reviewed changes
guides/release/components/the-component-lifecycle.md Outdated Show resolved Hide resolved
guides/release/routing/query-params.md Outdated Show resolved Hide resolved
guides/release/templates/input-helpers.md Outdated Show resolved Hide resolved
guides/release/templates/input-helpers.md Outdated Show resolved Hide resolved
guides/release/templates/links.md Outdated Show resolved Hide resolved
guides/release/templates/links.md Outdated Show resolved Hide resolved
guides/release/testing/testing-components.md Outdated Show resolved Hide resolved
guides/release/components/triggering-changes-with-actions.md Outdated Show resolved Hide resolved
guides/release/components/triggering-changes-with-actions.md Outdated Show resolved Hide resolved
guides/release/templates/binding-element-attributes.md Outdated Show resolved Hide resolved
MelSumner
MelSumner previously requested changes Jun 3, 2019
View reviewed changes
guides/release/components/the-component-lifecycle.md Outdated Show resolved Hide resolved
guides/release/routing/defining-your-routes.md Show resolved Hide resolved
guides/release/routing/defining-your-routes.md Outdated Show resolved Hide resolved
guides/release/routing/defining-your-routes.md Show resolved Hide resolved
guides/release/testing/testing-components.md Outdated Show resolved Hide resolved
guides/release/testing/testing-components.md Outdated Show resolved Hide resolved
@kategengler kategengler mentioned this pull request Jun 6, 2019
Closed
8 tasks
locks and others added 10 commits June 28, 2019 01:35
@locks
Update link-to to angle bracket invocation style
9a4431e
@locks
Update input and textarea to angle bracket invocation
4a485c1
@locks
fixup! Update link-to to angle bracket invocation style
844acdf
@locks @rwjblue
Update guides/release/routing/query-params.md
0a70b4e 
Co-Authored-By: Robert Jackson <[email protected]>
@locks @rwjblue
Update guides/release/templates/input-helpers.md
1828070 
Co-Authored-By: Robert Jackson <[email protected]>
@locks @rwjblue
Update guides/release/templates/links.md
1950164 
Co-Authored-By: Robert Jackson <[email protected]>
@locks @rwjblue
Update guides/release/templates/links.md
660d837 
Co-Authored-By: Robert Jackson <[email protected]>
@locks @rwjblue
Update guides/release/components/triggering-changes-with-actions.md
627a475 
Co-Authored-By: Robert Jackson <[email protected]>
@locks @rwjblue
Update guides/release/components/triggering-changes-with-actions.md
e99a9bb 
Co-Authored-By: Robert Jackson <[email protected]>
@locks @rwjblue
Update guides/release/templates/input-helpers.md
035dcd9 
Co-Authored-By: Robert Jackson <[email protected]>
@locks
Copy link
Contributor Author

locks commented Jun 28, 2019

I have updated the prose, please review!

acorncom
acorncom approved these changes Jul 2, 2019
View reviewed changes
guides/release/templates/input-helpers.md
@@ -52,7 +52,7 @@ To dispatch an action on specific events such as `key-press`, use the following

```handlebars
<label for="firstname">First Name</label>
{{input id="firstname" value=this.firstName key-press=(action "updateFirstName")}}
<Input @id="firstname" @value={{this.firstName}} @key-press={{action "updateFirstName"}} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@locks we're recommending key-press here and keypress in the next section down. Should we land on a standard approach? I don't see that this should block this PR, but might be worth a follow up PR to clean up?

@acorncom acorncom dismissed MelSumner’s stale review July 2, 2019 17:34

Items have been addressed

@acorncom acorncom mentioned this pull request Jul 2, 2019
Closed
@acorncom acorncom dismissed rwjblue’s stale review July 2, 2019 17:43

Items have been addressed

@acorncom
Copy link
Member

acorncom commented Jul 2, 2019

Thanks for your work on this @locks

@acorncom acorncom merged commit bdc04e4 into master Jul 2, 2019
@acorncom acorncom deleted the link-to-and-input branch July 2, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelSumner MelSumner MelSumner left review comments

@acorncom acorncom acorncom approved these changes

@sivakumar-kailasam sivakumar-kailasam sivakumar-kailasam left review comments

@rwjblue rwjblue rwjblue left review comments

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@locks @acorncom @rwjblue @NullVoxPopuli @sivakumar-kailasam @MelSumner