A 'deleteObject' from a hasMany relation with an object not included in the collection, deletes another object within the collection

[eodb]

Reproduction

Following straight forward qunit test can be copied to quickly reproduce the issue:

import { run } from '@ember/runloop';
import Model, { attr, belongsTo, hasMany } from '@ember-data/model';
import { setupTest } from 'ember-qunit';
import { module, test } from 'qunit';

let store;

module('integration/relationship/deleteObject from hasMany relation', function (hooks) {
  setupTest(hooks);

  hooks.beforeEach(function () {
    class Job extends Model {
      @attr name;
      @hasMany('message', { async: true, inverse: 'job' }) messages;
    }

    class Message extends Model {
      @attr msg;
      @belongsTo('job', { async: true, inverse: 'messages' }) job;
    }

    store = this.owner.lookup('service:store');
    this.owner.register('model:job', Job);
    this.owner.register('model:message', Message);
  });

  test('deleteObject of hasMany relation', async function (assert) {
    let job;
    let msg1;
    let msg2;
    let msg3;

    run(() => {
      job = store.createRecord('job', { name: 'my job' });
    });
    assert.ok(job, 'job created');

    run(() => {
      msg1 = store.createRecord('message', { job: job, msg: '1st msg' });
      msg2 = store.createRecord('message', { job: job, msg: '2nd msg' });
      msg3 = store.createRecord('message', { msg: '3rd msg' }); // 3rd msg, not part of the job
    });

    await run(() => {
      return job.messages.then((msgs) => {
        assert.equal(msgs.length, 2, 'job has 2 messages');
        assert.ok(msgs.includes(msg1), 'msg1 included');
        assert.ok(msgs.includes(msg2), 'msg2 included');
        // try to delete an object that is not included in the collection
        assert.notOk(msgs.includes(msg3), 'msg3 is not included');
        msgs.removeObject(msg3);
      });
    });

    run(() => {
      assert.equal(
        job.messages.length,
        2,
        'job still has 2 messages after an attempt to delete an object that is not part of the collection'
      );
    });
  });
});

Description

One expects that an attempt to delete an object from a hasMany relationship that is not included in the collection, should have no effect. Instead some other object from the collection seems to be deleted (see last failing assert: the resulting collection only contains one element anymore instead of the original two elements).

I tested this with an AsyncHasMany relation (async=true), but it also fails when the relation is defined as synchronous (async=false).

Versions

This scenario did work in ember-data 4.4.0 but not anymore with 4.8.3.
Tests were done with:

DEBUG: Ember      : 4.8.2
DEBUG: Ember Data : 4.8.3

[runspired]

Probably the shim to deprecate removeObject allows negative indexes as native splice allows negative. Should be an easy guard to add here:

data/packages/store/addon/-private/record-arrays/identifier-array.ts

Line 667 in 965eb0a

objs.forEach((obj) => this.splice(this.indexOf(obj), 1));

[runspired]

@jrjohnson this could be an easy one for you <3

[rossketron]

Is this issue currently being worked on by anyone? If not, I'd like to work on it!

[jrjohnson]

Go for it @rossketron!