Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only remove object(s) from record array if in collection #8318 #8323

Merged
merged 4 commits into from
Dec 7, 2022
Merged

fix: Only remove object(s) from record array if in collection #8318 #8323

merged 4 commits into from
Dec 7, 2022

Conversation

rossketron
Copy link
Contributor

Description

Fixes issue #8318.
Changes:

  • Only delete from record array if object exists in collection.
  • Fixes issue with splice accepting the -1 return value of indexOf as a negative index when object to remove was not found in collection.

Notes for the release

@runspired runspired added 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue labels Nov 28, 2022
@rossketron rossketron force-pushed the rossketron-fix-8318 branch 3 times, most recently from 2973188 to bf5b6c9 Compare December 1, 2022 01:06
@runspired runspired marked this pull request as ready for review December 1, 2022 01:16
@runspired runspired marked this pull request as draft December 1, 2022 01:16
@runspired runspired added 🎯 lts The PR should be backported to the most recent LTS and removed 🎯 release PR should be backported to release labels Dec 7, 2022
@runspired runspired marked this pull request as ready for review December 7, 2022 01:43
@runspired runspired merged commit 9b5ce4a into emberjs:master Dec 7, 2022
@rossketron rossketron deleted the rossketron-fix-8318 branch December 12, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossketron @runspired