[CLEANUP testing]: Remove PhantomJS from testing #5302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tbh -- I'm not sure what the config should be with appveyor, was mostly winging it from what I saw in |
|
The failures here are due to |
|
@alexander-alvarez would you mind trying to rebase this pr? |
Testing on firefox and chrome by default Equivalent to ember-cli/ember-cli#7148 And in line with https://github.com/emberjs/rfcs/blob/master/text/0252-browser-support-changes.md
alexander-alvarez
force-pushed
the
bye-bye-phantom
branch
from
48394bf
to
46182e3
Compare
|
Rebased (I still don't know how to debug the appveyor build) |
|
Thanks for looking into this @alexander-alvarez. I'm going to close this pr because I think this work has been superseded by #5342. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on firefox and chrome by default
Equivalent to ember-cli/ember-cli#7148
And in line with https://github.com/emberjs/rfcs/blob/master/text/0252-browser-support-changes.md