Refactor Travis setup to leverage stages... #5342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
refactor-CI-runs
branch
2 times, most recently
from
d7b7547
to
4dc13cd
Compare
rwjblue
changed the title
When running in PhantomJS the error message matched accidentally. This test should only be ran in debug builds because it is specifically testing an `Ember.assert` (which does not thrown in production).
rwjblue
force-pushed
the
refactor-CI-runs
branch
from
99b7e43
to
5b3ed02
Compare
|
Rebased on top of latest master to get Chrome passing (needed changes in #5340 to fix a new proxy related assertion)... |
|
Thanks @rwjblue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new(ish) stages feature from Travis allows us to fail early (and avoid wasting CI resources) when a "simple"
ember testwith locked deps does not pass.As you can see in the screenshot below:
The first stage is
test, and it uses our specificyarn.lockto runember test. If that build fails, nothing else is ran. If it succeeds 4 more builds are kicked off (production tests, optional-features, node-tests, floating dependencies). If any of those builds fail, nothing else is ran. Then it moves on to testing various Ember versions...