[BUGFIX beta] Update DS.Errors#unknownProperty to return undefined.
#5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be a BUGFIX beta |
In Ember 3.1+ any object that has an `unknownProperty` will throw an
error if its `unknownProperty` returns any value other than `undefined`
and the property is accessed via `obj.someProperty` (instead of
`obj.get('someProperty')` or `Ember.get(obj, 'someProperty')`).
rwjblue
force-pushed
the
fixes-for-canary-proxy-assertion
branch
from
e0d8af1
to
64d5620
Compare
rwjblue
changed the title
undefined.undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ember 3.1+ any object that has an
unknownPropertywill throw an error if itsunknownPropertyreturns any value other thanundefinedand the property is accessed viaobj.someProperty(instead ofobj.get('someProperty')orEmber.get(obj, 'someProperty')).