chore: convert store to ts #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2019
mike-north
approved these changes
Jul 11, 2019
runspired
force-pushed
the
cleanup/convert-store-to-ts
branch
from
84e1b28
to
771b36e
Compare
pete-the-pete
pushed a commit
to pete-the-pete/data
that referenced
this pull request
Jul 23, 2019
* chore: convert store.js to store.ts * drop type casting of Store * address @mnorth feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the "minimal possible conversion" to change
store.jstostore.ts. E.g. herein we are not attempting to "type" the Store, merely converting the file ending totsand making the minimal changes required such that it compiles.In the process I discovered a few things:
RSVPDeferredis only available on the "god object"@ember/utilstypeOfis missingobjectas a potential return value@ember/debugdeprecatehas not yet been added now that the confusion in Ember itself has been resolvedEmberENVis not typed, to which we are allowing users to supplyDS_WARN_ON_UNKNOWN_KEYS, we should likely phase this out.