Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC 403] Identifiers Infra #6247

Merged
merged 6 commits into from
Jul 19, 2019
Merged

[RFC 403] Identifiers Infra #6247

merged 6 commits into from
Jul 19, 2019

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Jul 11, 2019 •
edited
Loading

Implements the minimum infrastructure for RFC 403 (Identifiers)

Depends on #6246 #6245 #6244 #6239 #6161

This implementation does not provide public API access to the feature, but merely ensures that an identifier is created and correctly associated with every InternalModel.

A future PR will expose these APIs via feature flag in the locations specified by the RFC.

@runspired runspired requested a review from igorT July 11, 2019 07:50
@runspired runspired added the code-review Tracks PRs that require a code-review label Jul 11, 2019
@runspired runspired force-pushed the rfc-403-identifiers branch 2 times, most recently from f903c30 to 92facfe Compare July 11, 2019 23:59
@runspired
Copy link
Contributor Author

The ember-m3 failure is because M3 reaches into the InternalModelMap. We could provide a shim to preserve this but once identifiers work enters the cleanup phase that map will go away entirely anyway.

@runspired runspired mentioned this pull request Jul 12, 2019
Merged
mike-north
mike-north reviewed Jul 15, 2019
View reviewed changes
Copy link
Contributor

@mike-north mike-north left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS comments complete. Would be nice to have ie11 testing soon, now that we have branches that will only be entered in that runtime

packages/store/addon/-private/identifiers/cache.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/identifiers/cache.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/identifiers/cache.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/identifiers/cache.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/identifiers/cache.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/identifiers/cache.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/identifiers/cache.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/identifiers/cache.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/system/model/internal-model.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/system/relationships/state/belongs-to.ts Outdated Show resolved Hide resolved
igorT
igorT approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@igorT igorT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that some tests are coming along for all the creation/update part of it?

packages/store/addon/-private/identifiers/cache.ts Show resolved Hide resolved
packages/store/addon/-private/identifiers/cache.ts Show resolved Hide resolved
packages/store/addon/-private/identifiers/cache.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/identifiers/cache.ts Show resolved Hide resolved
packages/store/addon/-private/identifiers/cache.ts Show resolved Hide resolved
packages/store/addon/-private/identifiers/utils/uuid-v4.ts Show resolved Hide resolved
packages/store/addon/-private/system/model/internal-model.ts Show resolved Hide resolved
packages/store/addon/-private/system/model/internal-model.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/system/model/record-data.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/system/store.ts Show resolved Hide resolved
@runspired runspired merged commit 663856b into master Jul 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the rfc-403-identifiers branch July 19, 2019 08:21
runspired added a commit that referenced this pull request Jul 31, 2019
@runspired
Revert "[RFC 403] Identifiers Infra (#6247)"
50125ed 
This reverts commit 663856b.
runspired added a commit that referenced this pull request Aug 1, 2019
@runspired
Revert "[RFC 403] Identifiers Infra (#6247)"
9472e75 
This reverts commit 663856b.
runspired added a commit that referenced this pull request Aug 1, 2019
@runspired
Revert "[RFC 403] Identifiers Infra (#6247)"
c362544 
This reverts commit 663856b.
@runspired runspired mentioned this pull request Aug 22, 2019
Closed
@jelhan jelhan mentioned this pull request Sep 27, 2019
Closed
@rwjblue rwjblue mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorT igorT igorT approved these changes

@mike-north mike-north mike-north left review comments

Assignees
No one assigned
Labels
code-review Tracks PRs that require a code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runspired @mike-north @igorT