Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: eliminate store._getInternalModelForRecordData #6245

Merged
merged 1 commit into from
Jul 11, 2019
Merged

chore: eliminate store._getInternalModelForRecordData #6245

merged 1 commit into from
Jul 11, 2019

Conversation

runspired
Copy link
Contributor

eliminates a private method that only had one usage

@runspired runspired added the code-review Tracks PRs that require a code-review label Jul 11, 2019
@runspired runspired mentioned this pull request Jul 11, 2019
Merged
rwjblue
rwjblue approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick Ember Observer search for this too, no results found (other than ember-data itself).

@rwjblue rwjblue merged commit 792f4b4 into master Jul 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the cleanup/im-4-rd branch July 11, 2019 20:04
@rwjblue rwjblue added Cleanup and removed code-review Tracks PRs that require a code-review labels Jul 11, 2019
@runspired runspired added 🏷️ cleanup This PR primarily removes deprecated functionality and removed Cleanup labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
🏷️ cleanup This PR primarily removes deprecated functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runspired @rwjblue