Pass lid from relationship data to get record data #7425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snewcomer Can you please review this PR? |
runspired
requested changes
Feb 9, 2021
packages/-ember-data/tests/integration/identifiers/lid-reflection-test.ts
Outdated
Show resolved
Hide resolved
The issue appeared in the sideposting scenario: - model A has belongs to relationship to model B. - instance of model A and instance of model B are created on the client, - model A is saved along with model B sent in `include` section of payload; the linking is done through `lid` - server persisted both models and sent the response with server-generated `id` along with `lid` sent by the client. - when belongsTo.updateData() was called while the response payload was pushed to the store it couldn't match the record which was already in the store with the record data contained in the relationship data because `lid` was omitted. Add a test which ensures that the belongsTo() relationship has correct status in the sideposting with lid scenario.
|
@igorT the branch is green! Can we get it merged? |
runspired
approved these changes
Apr 8, 2021
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #7424.
The issue appeared in the sideposting scenario:
includesection of payload; the linking is done throughlididalong withlidsent by the client.lidwas omitted.Add a test which ensures that the belongsTo() relationship has correct status in the sideposting with lid scenario.