Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 3.28 release #1029

Merged
merged 11 commits into from
Sep 7, 2021
Merged

Ember 3.28 release #1029

merged 11 commits into from
Sep 7, 2021

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Aug 31, 2021

TODO

1. Ember.js

Bug Fixes

  • #19697 Ensure deserializeQueryParam is called for lazy routes
  • #19681 Restore previous hash behavior
  • #19685 Fix memory leak in RouterService
  • #19690 Deprecates String.prototype.htmlSafe targeting Ember 4.0, as intended by the original deprecation.
  • #19584 Ensure hash objects correctly entangle as dependencies
  • #19491 Fix owner.lookup owner.register behavior with singleton: true option
  • #19472 Prevent transformation of block params called attrs

Changelog

2. Ember Data

Bug Fixes

  • #7651 Return inflight requests for findRecord when CUSTOM_MODEL_CLASS is on
  • #7652 Fix for CUSTOM_MODEL_CLASS and deprecate passing non ember data records to unloadRecord and deleteRecord
  • #7643 @ember-data/model: Simplify @cached transpilation
  • #7554 reset previously failed linked async belongs-to now works
  • #7532 fix: belongsTo should not attempt load if inverse in payload provided its data
  • #7550 fix: add asserts and assert tests for belongsTo/hasMany/findRecord empty responses
  • #7534 fix: Ensure meta and links update when fetched relationship is empty or does not include the data key
  • #7545 assert when 'content' is used as a property on a record
  • #7531 fix: Closes issue preventing debug adapter removal from prod builds using the ember-data package
  • #7527 rollup step should deactivate ember modules polyfill >= 3.27
  • #7425 Pass lid from relationship data to get record data
  • #7448 coalesceFindRequests should work with non native Adapter classes
  • #7463 chore: cleanup Implicit relationships
  • #7453 chore: burndown of InternalModel methods that can be eliminated safely
  • #7226 refactor: Native Model
  • #7470 chore: convert relationships to use identifiers

Features

  • #7258 feat: record.destroyRecord should also unload the record
  • #7510 feat: activate all feature flags related to CUSTOM_MODEL_CLASSES

Changelog

3. Ember CLI

  • #9505 Pass realPath as root rather than the dirname for addonMainPath
  • #9507 Add a new config, ember-addon.projectRoot, to specify the location of the project
  • #9530 Drop Node 10 support
  • #9487 Add support for creating a single addon instance per bundle root (which enables dramatically reducing the total number of addon instances)
  • #9524 Update CONTRIBUTING.md to reference cli.emberjs.com
  • #9533 Ensure package-info objects are stable when they represent the same addon
  • #9538 ensure backwards compatibility is maintained with packageRoot and root
  • #9539 avoid setting root as realPath from the package-info object
  • #9537 Implement LCA host/host addons logic in ember-cli
  • #9540 Use relative override paths in blueprint ESLint config
  • #9542 Add validation checks for addon instance bundle caching
  • #9543 Add ability to specify a custom ember-addon.perBundleAddonCacheUtil utility
  • #9562 Update addon-proxy to support Embroider
  • #9565 Drop Node 10 support in blueprint engine spec
  • #9568 [BUGFIX release] Skip babel for qunit with embroider

Changelog

@jenweber
Copy link
Contributor

jenweber commented Sep 2, 2021

Hello reviewers, please look over the changelog above and let me know which if any additional items should be specifically highlighted.

Please also read over my changes to the intro to confirm that they are true. I borrowed some verbage from our final 2.x release post.

Once the blog post is almost ready to go, we'll do the guides/api docs just before it's published.

Thanks for your help!

@MelSumner
Copy link
Member

@jenweber I made some suggestions, I hope it helps. Maybe @kategengler would have some good context too. 👍

@mixonic
Copy link
Contributor

mixonic commented Sep 6, 2021

I've taken another pass here. I propose we aim to land this the morning of September 7th.

@mixonic mixonic marked this pull request as ready for review September 6, 2021 20:30
@mixonic mixonic merged commit 35299c2 into main Sep 7, 2021
@mixonic mixonic deleted the release-3-28 branch September 7, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants