dependencySatisfies only reliable with a peerDep

[ef4]

This addon uses dependencySatisfies to check the ember-source version. But unless you have a peerDep on ember-source, that was unreliable depending on Yarn/NPM optimization behaviors. And now as of embroider-build/embroider#1070 we're making dependencySatisfies strict so that it won't accidentally work sometimes when you don't actually declare a dependency or peerDependency.

[NullVoxPopuli]

💯
I totally meant to PR this myself and forgot 😅

thank you!!!

[SergeAstapov]

💯needed change!

@ef4 do you think build failure is related?

ERROR Summary:
122

123
  - broccoliBuilderErrorStack: TypeError: Cannot read property 'version' of undefined
124
    at CompatAppAdapter.makeAdjustImportOptions (/home/runner/work/ember-render-modifiers/ember-render-modifiers/node_modules/@embroider/compat/src/compat-app.js:286:80)
125
    at CompatAppAdapter.adjustImportsOptions (/home/runner/work/ember-render-modifiers/ember-render-modifiers/node_modules/@embroider/compat/src/compat-app.js:275:21)
126
    at CompatAppAdapter.<anonymous> (/home/runner/work/ember-render-modifiers/ember-render-modifiers/node_modules/typescript-memoize/dist/memoize-decorator.js:132:52)
127
    at AppBuilder.get resolvableExtensionsPattern (/home/runner/work/ember-render-modifiers/ember-render-modifiers/node_modules/@embroider/core/src/app.js:150:66)

[ef4]

Probably not caused by this PR, but legitimate problems caused by recent embroider releases. I will look into it.

[ef4]

I think this failure was hitting a bug that is already fixed in newer embroider releases:

embroider-build/embroider@8261003

Going to update @embroider/test-setup so it's testing against that fix.

[ef4]

This is ready to go. I would add that because this addon is very trusting with its semver range of @embroider/macros, this is somewhat urgent to release because people will get embroider-build/embroider#1070 automatically and break.

[ef4]

I see I already have bits to release, so I will release.